Bug 131064

Summary:

[CSS Grid Layout] Split the grid-item-margin-auto-columns-rows.html test.

Product:

WebKit

Reporter:

Javier Fernandez <jfernandez>

Component:

Layout and Rendering

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

benjamin, commit-queue, darin, jfernandez, kling, rego, svillar

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

60731

Attachments:

Description	Flags
Patch	none
Patch	none

Description Javier Fernandez 2014-04-01 14:20:16 PDT

Reference tests do have a limitation in that they only work if the test result fits into a relatively small-sized window. 

Splitting this test in two, horizontal and vertical layout, would be enough to make it fit in the 800x600 viewport.

Comment 1 Javier Fernandez 2014-04-01 16:04:55 PDT

Created attachment 228333 [details]
Patch

Comment 2 Javier Fernandez 2014-04-30 14:07:26 PDT

Darin, what do you think about the new tests ?

Comment 3 Javier Fernandez 2014-05-06 11:00:49 PDT

ping reviewers.

Comment 4 Javier Fernandez 2014-05-22 02:21:00 PDT

Ping reviewers. Thanks.

Comment 5 Benjamin Poulain 2014-05-22 02:46:33 PDT

Comment on attachment 228333 [details]
Patch

Splitting text seems like a good idea. Just rename the horiz and vert to horizontal and vertical. No point in abbreviating.
Shouldn't grid-item-margin-auto-columns-rows be named horizontal-ltr for consistency? Does it test something else?

Comment 6 Javier Fernandez 2014-05-22 03:28:28 PDT

Created attachment 231874 [details]
Patch

Renamed horiz and vert to horizontal and vertical. The basic test was renamed to horitonzal-ltr for consistency, as suggested.

Comment 7 WebKit Commit Bot 2014-05-22 05:02:03 PDT

Comment on attachment 231874 [details]
Patch

Clearing flags on attachment: 231874

Committed r169197: <http://trac.webkit.org/changeset/169197>

Comment 8 WebKit Commit Bot 2014-05-22 05:02:07 PDT

All reviewed patches have been landed.  Closing bug.