Bug 131048

Summary:

Stub out the web process -> UI process message SPI

Product:

WebKit

Reporter:

Anders Carlsson <andersca>

Component:

New Bugs

Assignee:

Anders Carlsson <andersca>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	sam: review+

Description Anders Carlsson 2014-04-01 11:00:13 PDT

Stub out the web process -> UI process message SPI

Comment 1 Anders Carlsson 2014-04-01 11:02:36 PDT

Created attachment 228301 [details]
Patch

Comment 2 WebKit Commit Bot 2014-04-01 11:05:01 PDT

Attachment 228301 [details] did not pass style-queue:


ERROR: Source/WebKit2/UIProcess/API/Cocoa/WKWebViewConfigurationPrivate.h:39:  Missing spaces around =  [whitespace/operators] [4]
Total errors found: 1 in 12 files


If any of these errors are false positives, please file a bug against check-webkit-style.

Comment 3 Sam Weinig 2014-04-01 11:07:21 PDT

Comment on attachment 228301 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228301&action=review

> Source/WebKit2/UIProcess/API/Cocoa/_WKScriptMessage.mm:45
> +
> +@end

You are missing name and scriptWorld.

> Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentController.mm:33
> +- (id <_WKScriptMessageHandlerToken>)addScriptMessageHandler:(id <_WKScriptMessageHandler>)scriptMessageHandler name:(NSString *)name world:(_WKScriptWorld *)world

This should not have a return value.

> Source/WebKit2/UIProcess/API/Cocoa/_WKUserContentController.mm:39
> +- (void)removeScriptMessageHandler:(id <_WKScriptMessageHandlerToken>)scriptMessageHandlerToken

This has the wrong signature.

Comment 4 Anders Carlsson 2014-04-01 11:48:54 PDT

Committed r166598: <http://trac.webkit.org/changeset/166598>