Summary: | [EFL] Make XVFBDriver optional | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Zsolt Borbely <zsborbely.u-szeged> | ||||
Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | clopez, commit-queue, glenn, gyuyoung.kim, lucas.de.marchi, ossy | ||||
Priority: | P2 | ||||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Zsolt Borbely
2014-04-01 08:17:28 PDT
Tools/Scripts/webkitpy/port/efl.py def _driver_class(self): return XvfbDriver It is good for a workaround. If we remove these two lines the tests will run. But unfortunatelly we can't decide the tests are runned as layout or as performation by the driver. That's why we should search a possible solution. You can use an environment variable. For example, on the GTK port we have: def _driver_class(self): if os.environ.get("WAYLAND_DISPLAY"): return WestonDriver return XvfbDriver Created attachment 231366 [details]
Patch
I want to commit this manually, because first I have to revert a local workaround in the perf-bot.
Comment on attachment 231366 [details]
Patch
rs=me.
Comment on attachment 231366 [details] Patch Clearing flags on attachment: 231366 Committed r168833: <http://trac.webkit.org/changeset/168833> All reviewed patches have been landed. Closing bug. |