Bug 130988

Summary: Improve GC_LOGGING
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review+

Description Mark Hahnenberg 2014-03-31 14:43:08 PDT 
GC_LOGGING can be useful for diagnosing where we're spending our time during collection, but it doesn't distinguish between Eden and Full collections in the data it gathers. We should update it so it can.
Comment 1 Mark Hahnenberg 2014-03-31 14:46:13 PDT 
Created attachment 228205 [details]
Patch
Comment 2 Mark Hahnenberg 2014-03-31 14:47:12 PDT 
Created attachment 228206 [details]
Patch
Comment 3 Mark Hahnenberg 2014-03-31 14:53:59 PDT 
Created attachment 228207 [details]
Patch
Comment 4 Geoffrey Garen 2014-03-31 15:58:54 PDT 
Comment on attachment 228207 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228207&action=review

r=me

> Source/JavaScriptCore/ChangeLog:9
> +        of input to be able to distinguish between the output of multiples processes exiting at the 

"multiple"

> Source/JavaScriptCore/heap/Heap.cpp:91
> +    struct Data {

"struct ElapsedTime"? "struct TimeRecord"?
Comment 5 Mark Hahnenberg 2014-03-31 16:27:57 PDT 
Committed r166544: <http://trac.webkit.org/changeset/166544>