Bug 130988

Summary: Improve GC_LOGGING
Product: WebKit Reporter: Mark Hahnenberg <mhahnenberg>
Component: JavaScriptCoreAssignee: Mark Hahnenberg <mhahnenberg>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch ggaren: review+

Mark Hahnenberg
Reported 2014-03-31 14:43:08 PDT
GC_LOGGING can be useful for diagnosing where we're spending our time during collection, but it doesn't distinguish between Eden and Full collections in the data it gathers. We should update it so it can.
Attachments
Patch (5.56 KB, patch)
2014-03-31 14:46 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (5.51 KB, patch)
2014-03-31 14:47 PDT, Mark Hahnenberg 		no flags
DetailsFormatted DiffDiff
Patch (5.89 KB, patch)
2014-03-31 14:53 PDT, Mark Hahnenberg 		ggaren: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Mark Hahnenberg
Comment 1 2014-03-31 14:46:13 PDT
Created attachment 228205 [details] Patch
Mark Hahnenberg
Comment 2 2014-03-31 14:47:12 PDT
Created attachment 228206 [details] Patch
Mark Hahnenberg
Comment 3 2014-03-31 14:53:59 PDT
Created attachment 228207 [details] Patch
Geoffrey Garen
Comment 4 2014-03-31 15:58:54 PDT
Comment on attachment 228207 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228207&action=review r=me > Source/JavaScriptCore/ChangeLog:9 > + of input to be able to distinguish between the output of multiples processes exiting at the "multiple" > Source/JavaScriptCore/heap/Heap.cpp:91 > + struct Data { "struct ElapsedTime"? "struct TimeRecord"?
Mark Hahnenberg
Comment 5 2014-03-31 16:27:57 PDT
Committed r166544: <http://trac.webkit.org/changeset/166544>
Note You need to log in before you can comment on or make changes to this bug.