Bug 130961

Summary: Upgrade to SelectorFailsAllSiblings failure when Child selector is failed
Product: WebKit Reporter: Yusuke Suzuki <ysuzuki>
Component: CSSAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: allan.jensen, benjamin, commit-queue, esprehn+autocc, glenn, gyuyoung.kim, macpherson, menard
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch benjamin: review+

Yusuke Suzuki
Reported 2014-03-31 01:02:44 PDT
When Child selector fails, we should resume matching from the closest Descendant selector. So upgrading SelectorFailsLocally to SelectorFailsAllSibling at least to prevent unnecessary direct/indirect adjacent selectors matching.
Attachments
Patch (2.26 KB, patch)
2014-03-31 01:07 PDT, Yusuke Suzuki 		benjamin: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1 2014-03-31 01:07:17 PDT
Created attachment 228158 [details] Patch
Yusuke Suzuki
Comment 2 2014-03-31 09:49:39 PDT
To clearify the executing model in my mind, I've created a small patch to match markRecursively's resuming strategy to CSS JIT's.
Benjamin Poulain
Comment 3 2014-04-04 15:28:41 PDT
Comment on attachment 228158 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=228158&action=review Great idea! > Source/WebCore/css/SelectorChecker.cpp:219 > + nextContext.elementStyle = 0; You can change this to nullptr now that WebKit supports C++ 11.
Benjamin Poulain
Comment 4 2014-04-04 15:31:12 PDT
Committed r166808: <http://trac.webkit.org/changeset/166808>
Yusuke Suzuki
Comment 5 2014-04-05 00:37:31 PDT
Thank you for your review and fixing 0 to nullptr!
Note You need to log in before you can comment on or make changes to this bug.