Bug 130951

Summary: Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: Tools / TestsAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, ggaren, mark.lam, mhahnenberg, msaboff, oliver, ossy, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
the patch ggaren: review+

Filip Pizlo
Reported 2014-03-30 20:10:06 PDT
Patch forthcoming.
Attachments
the patch (682.42 KB, patch)
2014-03-30 20:11 PDT, Filip Pizlo 		ggaren: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Filip Pizlo
Comment 1 2014-03-30 20:11:47 PDT
Created attachment 228139 [details] the patch
Csaba Osztrogonác
Comment 2 2014-03-31 04:07:28 PDT
Comment on attachment 228139 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review > Tools/ChangeLog:3 > + Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping in this patch. Referencing to an Apple internal script in the changelog is confusing.
Geoffrey Garen
Comment 3 2014-04-01 15:12:52 PDT
Comment on attachment 228139 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review >> Tools/ChangeLog:3 >> + Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running > > I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping > in this patch. Referencing to an Apple internal script in the changelog is confusing. "//@ skip" skips a test. I wonder, why isn't the run-jsc-benchmarks script open source?
Filip Pizlo
Comment 4 2014-04-01 15:36:36 PDT
(In reply to comment #3) > (From update of attachment 228139 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228139&action=review > > >> Tools/ChangeLog:3 > >> + Move slow JSRegress tests out of the way so that they don't show up in run-jsc-benchmarks runs and also skip tests that are extremely long-running > > > > I haven't find this run-jsc-benchmarks script in WebKit trunk and any test skipping > > in this patch. Referencing to an Apple internal script in the changelog is confusing. > > "//@ skip" skips a test. > > I wonder, why isn't the run-jsc-benchmarks script open source? It's sort of open source. See Tools/Scripts/bencher. run-jsc-benchmarks is a customized version of this script that directly references tests that can't be landed in the WebKit repository despite being otherwise publicly available, like Kraken and JSBench.
Filip Pizlo
Comment 5 2014-04-07 11:46:15 PDT
Landed in http://trac.webkit.org/changeset/166877
Note You need to log in before you can comment on or make changes to this bug.