| Summary: | LiveNodeLists should use ElementDescendantIterator | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||
| Component: | DOM | Assignee: | Nobody <webkit-unassigned> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, gyuyoung.kim, kangil.han, kling, rniwa | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antti Koivisto
2014-03-29 12:44:18 PDT
Created attachment 228114 [details]
patch
Attachment 228114 [details] did not pass style-queue:
ERROR: Source/WebCore/dom/ElementDescendantIterator.h:338: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
ERROR: Source/WebCore/dom/ElementDescendantIterator.h:341: value_type is incorrectly named. Don't use underscores in your identifier names. [readability/naming/underscores] [4]
Total errors found: 2 in 8 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Comment on attachment 228114 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=228114&action=review r=me, very glorious patch A+! > Source/WebCore/dom/CollectionIndexCache.h:38 > + CollectionIndexCache(const Collection&); explicit |