Summary: | LongSpider 3d-morph result check is inappropriate | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mark Lam <mark.lam> | ||||
Component: | JavaScriptCore | Assignee: | Mark Lam <mark.lam> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue, fpizlo, ggaren, mhahnenberg, mmirman, msaboff, oliver, rniwa | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
Mark Lam
2014-03-29 11:14:23 PDT
Created attachment 228111 [details]
the patch.
Comment on attachment 228111 [details]
the patch.
What is the running time of this test before and after your change?
(In reply to comment #3) > (From update of attachment 228111 [details]) > What is the running time of this test before and after your change? 3 runs of LongSpider 3d-morph each for before and after (x86_64 on a MBA): Before: 3d-morph 1252.2394+-34.5523 3d-morph 1253.3269+-55.5660 3d-morph 1264.6942+-91.1279 After: 3d-morph 1238.6026+-6.3175 3d-morph 1253.9030+-54.6123 3d-morph 1253.1157+-20.7673 I’d say it’s a wash. Thanks for the review. Landed in r166462: <http://trac.webkit.org/r166462>. |