Bug 130919 – [MSE][Mac] Support lease-renewal.

• Component: New Bugs
• Status: RESOLVED FIXED

[Jer Noble]

[MSE][Mac] Support lease-renewal.

[Jer Noble]

Created attachment 228093 [details]
Patch

[WebKit Commit Bot]

Comment on attachment 228093 [details]
Patch

Clearing flags on attachment: 228093

Committed r166509: <http://trac.webkit.org/changeset/166509>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.

[Darin Adler]

Comment on attachment 228093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=228093&action=review

> Source/WebCore/platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.mm:116
> +    static NeverDestroyed<String> renewMessage("renew");
> +    String keyAsString(key->data(), key->length());
> +
> +    if (keyAsString == renewMessage) {

This is a tortured way to check if the key is "renew". I suggest writing a function to do it without memory allocation. Maybe put it in a header somewhere, but at least do it within this file for now:

    static bool isEqual(const uint8_t* data, unsigned length, const char* literal)
    {
        for (unsigned i = 0; i < length; ++i) {
            if (data[i] != static_cast<uint8_t>(literal[i]))
                return false;
        }
        return !literal[length];
    }

Then get rid of the renewMessage and keyAsStringLocal variables. And write:

    if (isEqual(key->data(), key->length(), "renew") {