Bug 130906 – AX: Need ability to get line range for text marker.

• Component: Accessibility
• Status: RESOLVED FIXED

[Samuel White]

We need the ability to fetch the range of an entire line given any arbitrary text marker on that line. Currently, getting the range of a line given a marker can be pretty expensive and requires a handful of IPC calls. We already have this ability for paragraphs and sentences so this is a natural 'next' step.

I'm thinking:
AXLineTextMarkerRangeForTextMarker

[Radar WebKit Bug Importer]

<rdar://problem/16458741>

[Radar WebKit Bug Importer]

<rdar://problem/16458746>

[chris fleizach]

(In reply to comment #0)
> We need the ability to fetch the range of an entire line given any arbitrary text marker on that line. Currently, getting the range of a line given a marker can be pretty expensive and requires a handful of IPC calls. We already have this ability for paragraphs and sentences so this is a natural 'next' step.
> 
> I'm thinking:
> AXLineTextMarkerRangeForTextMarker

If you're getting the text back, I'd say LineText. If you're getting a TextMarkerRange back, maybe better would be

AXLineMarkerRangeForTextMarker

[Samuel White]

Created attachment 228077 [details]
Patch for EWS.

Just looking for platform failures. Will address naming feedback in next patch.

[Samuel White]

(In reply to comment #3)
> (In reply to comment #0)
> > We need the ability to fetch the range of an entire line given any arbitrary text marker on that line. Currently, getting the range of a line given a marker can be pretty expensive and requires a handful of IPC calls. We already have this ability for paragraphs and sentences so this is a natural 'next' step.
> > 
> > I'm thinking:
> > AXLineTextMarkerRangeForTextMarker
> 
> If you're getting the text back, I'd say LineText. If you're getting a TextMarkerRange back, maybe better would be
> 
> AXLineMarkerRangeForTextMarker

After some additional consideration, I think we should keep the original name to better match existing similar attributes. Specifically:

AXParagraphTextMarkerRangeForTextMarker
AXSentenceTextMarkerRangeForTextMarker

Does this sound ok Chris, or do you think leaving 'text' may cause confusion?

[chris fleizach]

(In reply to comment #5)
> (In reply to comment #3)
> > (In reply to comment #0)
> > > We need the ability to fetch the range of an entire line given any arbitrary text marker on that line. Currently, getting the range of a line given a marker can be pretty expensive and requires a handful of IPC calls. We already have this ability for paragraphs and sentences so this is a natural 'next' step.
> > > 
> > > I'm thinking:
> > > AXLineTextMarkerRangeForTextMarker
> > 
> > If you're getting the text back, I'd say LineText. If you're getting a TextMarkerRange back, maybe better would be
> > 
> > AXLineMarkerRangeForTextMarker
> 
> After some additional consideration, I think we should keep the original name to better match existing similar attributes. Specifically:
> 
> AXParagraphTextMarkerRangeForTextMarker
> AXSentenceTextMarkerRangeForTextMarker
> 
> Does this sound ok Chris, or do you think leaving 'text' may cause confusion?

If those already exist, we might as well stick with that convention

[Build Bot]

Comment on attachment 228077 [details]
Patch for EWS.

Attachment 228077 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5248652536709120

New failing tests:
platform/mac/accessibility/bounds-for-range.html

[Build Bot]

Created attachment 228082 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[Samuel White]

Created attachment 228083 [details]
Patch.

Revised patch with build and test fixes. Also includes change log updates.

[chris fleizach]

Comment on attachment 228083 [details]
Patch.

View in context: https://bugs.webkit.org/attachment.cgi?id=228083&action=review

r=me assuming tests all pass

> Tools/DumpRenderTree/AccessibilityUIElement.cpp:1351
> +    return 0;

nullptr

[Samuel White]

Committed manually with requested change:
http://trac.webkit.org/changeset/166513

Closing.