Summary: | [GTK] Geoclue2 providers won't work after reloading | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Mario Sanchez Prada <mario> | ||||
Component: | WebKitGTK | Assignee: | Nobody <webkit-unassigned> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | cgarcia, commit-queue | ||||
Priority: | P2 | Keywords: | Gtk | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | All | ||||||
OS: | Linux | ||||||
Attachments: |
|
Description
Mario Sanchez Prada
2014-03-28 07:00:56 PDT
Created attachment 228049 [details]
Patch proposal
The fix is quite simple. Please consider reviewing it quickly so we can request integrating it into the stable branch before the next release.
Thanks!
Comment on attachment 228049 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=228049&action=review > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp:76 > - startGeoclueClient(); > + geoclue_manager_call_get_client(m_managerProxy.get(), nullptr, reinterpret_cast<GAsyncReadyCallback>(getGeoclueClientCallback), this); You don't mention in the changelog why you no longer call startGeoclueClient. (In reply to comment #2) > (From update of attachment 228049 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=228049&action=review > > > Source/WebCore/platform/geoclue/GeolocationProviderGeoclue2.cpp:76 > > - startGeoclueClient(); > > + geoclue_manager_call_get_client(m_managerProxy.get(), nullptr, reinterpret_cast<GAsyncReadyCallback>(getGeoclueClientCallback), this); > > You don't mention in the changelog why you no longer call startGeoclueClient. I no longer call him here because it will be called later on, once the client proxy is created, down in createGeoclueClientProxyCallback(). Not sure whether it's worth mentioning that in the ChangeLog? Comment on attachment 228049 [details]
Patch proposal
Thanks for the review!
Comment on attachment 228049 [details] Patch proposal Clearing flags on attachment: 228049 Committed r166406: <http://trac.webkit.org/changeset/166406> All reviewed patches have been landed. Closing bug. |