Bug 130850

Summary: Convert yet more of HTMLConverter to C++
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: ddkilzer
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch andersca: review+

Sam Weinig
Reported 2014-03-27 11:49:15 PDT
Convert yet more of HTMLConverter to C++
Attachments
Patch (47.51 KB, patch)
2014-03-27 15:21 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-03-27 15:21:54 PDT
Created attachment 227994 [details] Patch
Anders Carlsson
Comment 2 2014-03-27 16:31:12 PDT
Comment on attachment 227994 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227994&action=review > Source/WebCore/editing/cocoa/HTMLConverter.mm:560 > +NSAttributedString *HTMLConverter::convert() This should really return a RetainPtr<NSAttributedString>.
Sam Weinig
Comment 3 2014-03-29 13:03:41 PDT
Committed r166454: <http://trac.webkit.org/changeset/166454>
David Kilzer (:ddkilzer)
Comment 4 2014-03-30 12:51:58 PDT
iOS build fix: <http://trac.webkit.org/changeset/166464>
Note You need to log in before you can comment on or make changes to this bug.