| Summary: | ASSERTION FAILED: !m_clients.contains(c) in WebCore::CachedResource::ref(WebCore::CachedResourceClient*) | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | mitz | ||||||||||
| Component: | WebCore Misc. | Assignee: | Dave Hyatt <hyatt> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | hyatt | ||||||||||
| Priority: | P1 | Keywords: | HasReduction | ||||||||||
| Version: | 523.x (Safari 3) | ||||||||||||
| Hardware: | Mac | ||||||||||||
| OS: | OS X 10.4 | ||||||||||||
| URL: | http://www.usatoday.com/news/washington/2007-03-13-archives_N.htm | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
mitz
2007-03-15 11:49:46 PDT
Created attachment 13665 [details]
Reduction (will assert)
Working on it... Created attachment 13667 [details]
Add a method to get all images used by a renderer
I didn't change RenderListMarker, which ref()s its image if it has one, because list markers cannot have box decorations. I could do that for consistency if you think that's better.
Comment on attachment 13667 [details]
Add a method to get all images used by a renderer
I disagree with the idea of minimizing refs and derefs, since refs even on the same image need to count as accesses of the image.
However it is true that the same resource should not be getting multiple notifications for the same image load.
I think a better way to solve this problem is to convert the cached resource client set to be a counted set. That way multiple refs and derefs can still occur and we can still have meaningful asserts.
I will take care of this. Created attachment 13670 [details]
Convert to using a counted set in the cache.
Comment on attachment 13670 [details]
Convert to using a counted set in the cache.
r=me
Created attachment 13673 [details]
Tweak imageChanged in RenderImage and RenderListMarker
Comment on attachment 13673 [details]
Tweak imageChanged in RenderImage and RenderListMarker
r=me
Comment on attachment 13673 [details] Tweak imageChanged in RenderImage and RenderListMarker Landed <http://trac.webkit.org/projects/webkit/changeset/20242> Fixed. |