Summary: | Apply Character-level mirroring to stretchy operators in RTL mode | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||
Component: | MathML | Assignee: | Frédéric Wang (:fredw) <fred.wang> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bunhere, cdumez, cfleizach, commit-queue, dbarton, esprehn+autocc, glenn, gyuyoung.kim, kondapallykalyan, macpherson, menard, mrobinson, sergio | ||||||||||
Priority: | P2 | ||||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | All | ||||||||||||
OS: | All | ||||||||||||
Bug Depends on: | 130322 | ||||||||||||
Bug Blocks: | 123018 | ||||||||||||
Attachments: |
|
Description
Frédéric Wang (:fredw)
2014-03-27 08:07:36 PDT
Created attachment 227946 [details]
Patch
Created attachment 228830 [details]
Patch
Created attachment 228831 [details]
Patch+130322 for testing
Created attachment 232528 [details]
Patch
Committed r169617: <http://trac.webkit.org/changeset/169617> Comment on attachment 232528 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=232528&action=review > Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1587 > + index += index % 2 ? -1 : 1; There is likely a bug here. The new value assigned to index is never used because of the break below. Frederic, could you please check? I am not sure what was the intent because the chunk added here has no effect. (In reply to comment #6) > Comment on attachment 232528 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=232528&action=review > > > Source/WebCore/rendering/mathml/RenderMathMLOperator.cpp:1587 > > + index += index % 2 ? -1 : 1; > > There is likely a bug here. The new value assigned to index is never used > because of the break below. Frederic, could you please check? I am not sure > what was the intent because the chunk added here has no effect. I think the index change should have been done before the stretchyCharacter = &stretchyCharacters[index]; statement. |