Bug 130806

Summary:

Web Inspector: Give WebProcess a proxy application entitlement

Product:

WebKit

Reporter:

Joseph Pecoraro <joepeck>

Component:

Web Inspector

Assignee:

Joseph Pecoraro <joepeck>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

ap, buildbot, graouts, joepeck, rniwa, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
[PATCH] Proposed Fix	timothy: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2	none

Description Joseph Pecoraro 2014-03-26 17:47:53 PDT

This makes it easier to check that the application is a proxy when it connects to com.apple.webinspector.

<rdar://problem/16439021>

Comment 1 Joseph Pecoraro 2014-03-26 17:49:11 PDT

Created attachment 227900 [details]
[PATCH] Proposed Fix

Comment 2 Build Bot 2014-03-26 18:47:26 PDT

Comment on attachment 227900 [details]
[PATCH] Proposed Fix

Attachment 227900 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5159195347255296

New failing tests:
media/adopt-node-crash.html

Comment 3 Build Bot 2014-03-26 18:47:28 PDT

Created attachment 227908 [details]
Archive of layout-test-results from webkit-ews-09 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-09  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

Comment 4 Alexey Proskuryakov 2014-03-27 09:44:54 PDT

Will this work with nightly builds?

Comment 5 Timothy Hatcher 2014-03-27 11:58:57 PDT

This change was iOS only. Joe is aware of the impact entitlements will have on open source Mac builds and is proceeding with caution on what we do.

Comment 6 Joseph Pecoraro 2014-03-27 15:04:33 PDT

<http://trac.webkit.org/changeset/166371>