Bug 130803

Summary: Web Inspector: Modernize the loops in InspectorPageAgent.cpp
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Description Timothy Hatcher 2014-03-26 15:25:12 PDT
C++11 FTW!
Comment 1 Timothy Hatcher 2014-03-26 15:26:52 PDT
Created attachment 227891 [details]
Patch
Comment 2 Joseph Pecoraro 2014-03-26 15:40:17 PDT
Comment on attachment 227891 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227891&action=review

> Source/WebCore/inspector/InspectorPageAgent.cpp:455
> +    for (auto cookie : cookiesList)
> +        cookies->addItem(buildObjectForCookie(cookie));

I think we are making these new for loops either "auto*" or "auto&" to be explicit.
Comment 3 Timothy Hatcher 2014-03-26 15:47:30 PDT
Created attachment 227894 [details]
Patch
Comment 4 Joseph Pecoraro 2014-03-26 15:52:53 PDT
Comment on attachment 227894 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227894&action=review

r=me

> Source/WebCore/inspector/InspectorPageAgent.cpp:465
> +        auto cachedResource = cachedResourceHandle.get();

I think having CachedResource* here would be helpful instead of auto.
Comment 5 Timothy Hatcher 2014-03-26 16:20:40 PDT
Created attachment 227896 [details]
Patch
Comment 6 WebKit Commit Bot 2014-03-26 16:58:42 PDT
Comment on attachment 227896 [details]
Patch

Clearing flags on attachment: 227896

Committed r166329: <http://trac.webkit.org/changeset/166329>
Comment 7 WebKit Commit Bot 2014-03-26 16:58:45 PDT
All reviewed patches have been landed.  Closing bug.