Bug 130803

Summary: Web Inspector: Modernize the loops in InspectorPageAgent.cpp
Product: WebKit Reporter: Timothy Hatcher <timothy>
Component: Web InspectorAssignee: Timothy Hatcher <timothy>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, graouts, joepeck, timothy, webkit-bug-importer
Priority: P2 Keywords: DoNotImportToRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Timothy Hatcher
Reported 2014-03-26 15:25:12 PDT
C++11 FTW!
Attachments
Patch (7.58 KB, patch)
2014-03-26 15:26 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2014-03-26 15:47 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Patch (7.59 KB, patch)
2014-03-26 16:20 PDT, Timothy Hatcher 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Timothy Hatcher
Comment 1 2014-03-26 15:26:52 PDT
Created attachment 227891 [details] Patch
Joseph Pecoraro
Comment 2 2014-03-26 15:40:17 PDT
Comment on attachment 227891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227891&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:455 > + for (auto cookie : cookiesList) > + cookies->addItem(buildObjectForCookie(cookie)); I think we are making these new for loops either "auto*" or "auto&" to be explicit.
Timothy Hatcher
Comment 3 2014-03-26 15:47:30 PDT
Created attachment 227894 [details] Patch
Joseph Pecoraro
Comment 4 2014-03-26 15:52:53 PDT
Comment on attachment 227894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227894&action=review r=me > Source/WebCore/inspector/InspectorPageAgent.cpp:465 > + auto cachedResource = cachedResourceHandle.get(); I think having CachedResource* here would be helpful instead of auto.
Timothy Hatcher
Comment 5 2014-03-26 16:20:40 PDT
Created attachment 227896 [details] Patch
WebKit Commit Bot
Comment 6 2014-03-26 16:58:42 PDT
Comment on attachment 227896 [details] Patch Clearing flags on attachment: 227896 Committed r166329: <http://trac.webkit.org/changeset/166329>
WebKit Commit Bot
Comment 7 2014-03-26 16:58:45 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.