Summary: | Web Inspector: Modernize the loops in InspectorPageAgent.cpp | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Timothy Hatcher <timothy> | ||||||||
Component: | Web Inspector | Assignee: | Timothy Hatcher <timothy> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | DoNotImportToRadar | ||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | All | ||||||||||
OS: | All | ||||||||||
Attachments: |
|
Description
Timothy Hatcher
2014-03-26 15:25:12 PDT
Created attachment 227891 [details]
Patch
Comment on attachment 227891 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227891&action=review > Source/WebCore/inspector/InspectorPageAgent.cpp:455 > + for (auto cookie : cookiesList) > + cookies->addItem(buildObjectForCookie(cookie)); I think we are making these new for loops either "auto*" or "auto&" to be explicit. Created attachment 227894 [details]
Patch
Comment on attachment 227894 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227894&action=review r=me > Source/WebCore/inspector/InspectorPageAgent.cpp:465 > + auto cachedResource = cachedResourceHandle.get(); I think having CachedResource* here would be helpful instead of auto. Created attachment 227896 [details]
Patch
Comment on attachment 227896 [details] Patch Clearing flags on attachment: 227896 Committed r166329: <http://trac.webkit.org/changeset/166329> All reviewed patches have been landed. Closing bug. |