Bug 130792

Summary: Reasoning about DWARF register numbers should be moved out of FTL::Location
Product: WebKit Reporter: Filip Pizlo <fpizlo>
Component: JavaScriptCoreAssignee: Filip Pizlo <fpizlo>
Status: RESOLVED FIXED    
Severity: Normal CC: barraclough, commit-queue, ggaren, mark.lam, mhahnenberg, msaboff, oliver, sam
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Bug Depends on:    
Bug Blocks: 130791    
Attachments:
Description Flags
the patch
none
the patch oliver: review+

Description Filip Pizlo 2014-03-26 12:36:44 PDT 
So that it could be reused by the code I will eventually add for parsing the LiveOuts section of StackMaps.
Comment 1 Filip Pizlo 2014-03-26 12:39:05 PDT 
Created attachment 227876 [details]
the patch
Comment 2 Filip Pizlo 2014-03-26 12:40:19 PDT 
Created attachment 227877 [details]
the patch

Cleaned up a bit
Comment 3 WebKit Commit Bot 2014-03-26 12:43:03 PDT 
Attachment 227877 [details] did not pass style-queue:


ERROR: Source/JavaScriptCore/ftl/FTLDWARFRegister.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
ERROR: Source/JavaScriptCore/ftl/FTLDWARFRegister.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
Total errors found: 2 in 7 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 4 Filip Pizlo 2014-03-26 13:14:13 PDT 
(In reply to comment #3)
> Attachment 227877 [details] did not pass style-queue:
> 
> 
> ERROR: Source/JavaScriptCore/ftl/FTLDWARFRegister.cpp:27:  Found other header before a header this file implements. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
> ERROR: Source/JavaScriptCore/ftl/FTLDWARFRegister.cpp:31:  Alphabetical sorting problem.  [build/include_order] [4]
> Total errors found: 2 in 7 files
> 
> 
> If any of these errors are false positives, please file a bug against check-webkit-style.

Fixed.
Comment 5 Filip Pizlo 2014-03-26 13:51:25 PDT 
Landed in http://trac.webkit.org/changeset/166313