Bug 130784
| Summary: | Remove unnecessary conversion to TimeRanges | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Jeremy Jones <jeremyj-wk> |
| Component: | Media | Assignee: | Jeremy Jones <jeremyj-wk> |
| Status: | NEW | ||
| Severity: | Normal | CC: | ahmad.saleem792, ddkilzer, destra, eric.carlson, jer.noble, jonlee, webkit-bug-importer |
| Priority: | P2 | Keywords: | InRadar |
| Version: | 528+ (Nightly build) | ||
| Hardware: | iPhone / iPad | ||
| OS: | Unspecified | ||
Jeremy Jones
> > Source/WebKit2/UIProcess/ios/WebVideoFullscreenManagerProxy.mm:79
> > + setSeekableRanges(*timeRanges);
>
> Could you pass the Vector<> directly instead of creating a temporary TimeRanges?
The is one of a couple solutions.
1) Create an encoder/decoder for TimeRanges to they can cross IPC boundary. Thus removing the vector.
2) Pass Vector<> directly, which will unnecessarily convert TimeRanges to a Vector<> in WK1.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
David Kilzer (:ddkilzer)
<rdar://problem/28227915>
Ahmad Saleem
I am unable to find this in WebKit source (from searchfox.org):
'WebVideoFullscreenManagerProxy' -> does not exist.
'setSeekableRanges' -> using this as search term
__
Is it still applicable?