Summary: | [CSS Grid Layout] Prevent issues with checkLayout() in grid items | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Manuel Rego Casasnovas <rego> | ||||||||
Component: | Tools / Tests | Assignee: | Manuel Rego Casasnovas <rego> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | commit-queue, jfernandez, svillar | ||||||||
Priority: | P2 | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Manuel Rego Casasnovas
2014-03-26 01:27:33 PDT
Created attachment 227835 [details]
Patch
Comment on attachment 227835 [details]
Patch
There is an issue in the tests indeed, but moving the output to a single place worsens the expectations as it becomes more difficult to know which tests could be failing. Could it be possible to fix the issue without changing the expectations?
Created attachment 227842 [details]
Patch
I modified the patch to keep the same expectations. On top of that I realized that the the patch contained some uneeded changes, becaues of checkLayout for a grid is not a problem as results will be added to the parent and not the grid itself.
Comment on attachment 227842 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227842&action=review Much better indeed. > LayoutTests/ChangeLog:18 > + Nit: could you please try to keep columns <80 before landing? Readability of the ChangeLog is improved a lot. Created attachment 227843 [details]
Patch
Patch for landing.
Comment on attachment 227843 [details] Patch Clearing flags on attachment: 227843 Committed r166290: <http://trac.webkit.org/changeset/166290> All reviewed patches have been landed. Closing bug. |