Bug 130745
| Summary: | webkit-patch upload should complain if bug parameter doesn't match bug in Changelog | ||
|---|---|---|---|
| Product: | WebKit | Reporter: | Blaze Burg <bburg> |
| Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
| Status: | NEW | ||
| Severity: | Normal | CC: | abarth, darin, ddkilzer, llango.u-szeged, ossy, rniwa, simon.fraser |
| Priority: | P2 | ||
| Version: | 528+ (Nightly build) | ||
| Hardware: | Unspecified | ||
| OS: | Unspecified | ||
Blaze Burg
Several times now I've accidentally bumped other people's patches because webkit-patch upload doesn't check that -b <bugid> is the same as https://bugs.webkit.org/show_bug.cgi?id=<bugid> within the changelog header. This should be trivial to check, I think.
| Attachments | ||
|---|---|---|
| Add attachment proposed patch, testcase, etc. |
Csaba Osztrogonác
Just out of curiosity, why did you pass -b parameter to webkit-patch?
It parses the bug id from changelog and upload the patch to the proper bug.
László Langó
We should not allow -b <bugid> option in upload commands. It is unnecessary as Ossy mentioned and leads to issues.
Blaze Burg
(In reply to comment #1)
> Just out of curiosity, why did you pass -b parameter to webkit-patch?
> It parses the bug id from changelog and upload the patch to the proper bug.
Err, not -b, but just putting the bug number on the command line.
It's not obvious that the default behavior will parse the change log:
"upload uploads the current diff to bugs.webkit.org.
If no bug id is provided, upload will create a bug.
If the current diff does not have a ChangeLog, upload
will prepare a ChangeLog."
That first line from the help message makes it sound like it will unconditionally open a new bug. Does it?
László Langó
(In reply to comment #3)
> (In reply to comment #1)
> > Just out of curiosity, why did you pass -b parameter to webkit-patch?
> > It parses the bug id from changelog and upload the patch to the proper bug.
>
> Err, not -b, but just putting the bug number on the command line.
> It's not obvious that the default behavior will parse the change log:
>
> "upload uploads the current diff to bugs.webkit.org.
> If no bug id is provided, upload will create a bug.
> If the current diff does not have a ChangeLog, upload
> will prepare a ChangeLog."
>
> That first line from the help message makes it sound like it will unconditionally open a new bug. Does it?
It does, if no bugurl in the ChangeLog and neither "-b <bugid>". In this case asks for a bugtitle and a comment for the new bug.
I agree that the help message is not obvious.
We should avoid the wrong usage somehow. I think we shouldn't allow to use the bugurl in the ChangeLog and the -b "<bugid>" option at the same time. Or simply remove the "-b <bugid>" option from the upload command.