| Summary: | Avoid duplicate size checks when creating empty image | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | WebCore Misc. | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | commit-queue, esprehn+autocc, gyuyoung.kim | ||||
| Priority: | P2 | ||||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 227772 [details]
Patch
Comment on attachment 227772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227772&action=review > Source/WebCore/ChangeLog:19 > +2014-03-21 Brent Fulgham <bfulgham@apple.com> > + > + [iOS] Pass additional options to AVFoudnation during playback. > + https://bugs.webkit.org/show_bug.cgi?id=130624 > + oops Comment on attachment 227772 [details] Patch Rejecting attachment 227772 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227772, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5560090815889408 Committed r166300: <http://trac.webkit.org/changeset/166300> |
Size-checking logic in CanvasRenderingContext2D.cpp double-checks the size of the buffer, since the call to ImageData::create checks the size and returns nullptr on failure. No need to do this calculation twice. Merge from Blink: https://codereview.chromium.org/190633011