Bug 130730

Summary: Avoid duplicate size checks when creating empty image
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebCore Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, esprehn+autocc, gyuyoung.kim
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch dino: review+, commit-queue: commit-queue-

Brent Fulgham
Reported 2014-03-25 11:12:24 PDT
Size-checking logic in CanvasRenderingContext2D.cpp double-checks the size of the buffer, since the call to ImageData::create checks the size and returns nullptr on failure. No need to do this calculation twice. Merge from Blink: https://codereview.chromium.org/190633011
Attachments
Patch (2.62 KB, patch)
2014-03-25 11:19 PDT, Brent Fulgham 		dino: review+
commit-queue: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2014-03-25 11:19:04 PDT
Created attachment 227772 [details] Patch
Dean Jackson
Comment 2 2014-03-25 14:22:12 PDT
Comment on attachment 227772 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227772&action=review > Source/WebCore/ChangeLog:19 > +2014-03-21 Brent Fulgham <bfulgham@apple.com> > + > + [iOS] Pass additional options to AVFoudnation during playback. > + https://bugs.webkit.org/show_bug.cgi?id=130624 > + oops
WebKit Commit Bot
Comment 3 2014-03-26 09:47:16 PDT
Comment on attachment 227772 [details] Patch Rejecting attachment 227772 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-03', 'validate-changelog', '--check-oops', '--non-interactive', 227772, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in Source/WebCore/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/5560090815889408
Brent Fulgham
Comment 4 2014-03-26 10:02:46 PDT
Committed r166300: <http://trac.webkit.org/changeset/166300>
Note You need to log in before you can comment on or make changes to this bug.