Summary: | Eliminate a sync cancelComposition call in WebPageProxy::editorStateChanged | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Alexey Proskuryakov <ap> | ||||||
Component: | WebKit2 | Assignee: | Alexey Proskuryakov <ap> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | andersca, darin, enrica, sam | ||||||
Priority: | P2 | ||||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
Bug Depends on: | 130748 | ||||||||
Bug Blocks: | |||||||||
Attachments: |
|
Description
Alexey Proskuryakov
2014-03-25 10:25:59 PDT
Created attachment 227992 [details]
proposed patch
Created attachment 228056 [details]
with a build fix
Comment on attachment 228056 [details] with a build fix View in context: https://bugs.webkit.org/attachment.cgi?id=228056&action=review > Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4114 > +printf("didChangeSelection. hasComposition = %uï¼ignoreCompositionSelectionChange ï¼%u, isNone = %u\n", frame.editor().hasComposition(), frame.editor().ignoreCompositionSelectionChange(), frame.selection().isNone()); You have a printf here. Comment on attachment 228056 [details] with a build fix View in context: https://bugs.webkit.org/attachment.cgi?id=228056&action=review >> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:4114 >> +printf("didChangeSelection. hasComposition = %uï¼ignoreCompositionSelectionChange ï¼%u, isNone = %u\n", frame.editor().hasComposition(), frame.editor().ignoreCompositionSelectionChange(), frame.selection().isNone()); > > You have a printf here. You probably don't want to leave this in :-) Committed <http://trac.webkit.org/r166421>. |