Bug 130722

Summary:

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/

Product:

WebKit

Reporter:

Sergio Villar Senin <svillar>

Component:

New Bugs

Assignee:

Sergio Villar Senin <svillar>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

darin, koivisto, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

Bug Blocks:

130185

Attachments:

Description	Flags
Patch	none
Patch	koivisto: review+

Description Sergio Villar Senin 2014-03-25 09:55:56 PDT

Replace DEPRECATED_DEFINE_STATIC_LOCAL by static NeverDestroyed<T> in editing/

Comment 1 Sergio Villar Senin 2014-03-25 09:57:57 PDT

Created attachment 227763 [details]
Patch

Comment 2 Darin Adler 2014-03-25 20:31:39 PDT

Comment on attachment 227763 [details]
Patch

EWS bots show that we need more get() calls in AlternativeTextController.cpp

Comment 3 Sergio Villar Senin 2014-03-26 07:25:14 PDT

Created attachment 227849 [details]
Patch

Comment 4 Antti Koivisto 2014-03-26 07:39:02 PDT

Comment on attachment 227849 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227849&action=review

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:66
> +        oldObject.get() = 0;

nullptr

> Source/WebCore/editing/atk/FrameSelectionAtk.cpp:69
> +    AtkObject* oldAxObject = oldObject.get() ? oldObject.get()->wrapper() : 0;

nullptr

Comment 5 Sergio Villar Senin 2014-03-26 08:13:22 PDT

Committed r166294: <http://trac.webkit.org/changeset/166294>