Bug 130712

Summary:

Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Web Inspector

Assignee:

James Craig <jcraig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	timothy: review+
screen shot	none
patch	none

James Craig

Reported 2014-03-25 00:22:08 PDT

Web Inspector: AXI: add support for aria-activedescendant and UI/testing with parentNode

Attachments
patch (19.93 KB, patch) 2014-03-25 00:33 PDT, James Craig	timothy: review+	Details Formatted Diff Diff
screen shot (279.35 KB, image/png) 2014-03-25 00:47 PDT, James Craig	no flags	Details
patch (20.13 KB, patch) 2014-03-25 18:44 PDT, James Craig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-03-25 00:22:24 PDT

<rdar://problem/16416603>

James Craig

Comment 2 2014-03-25 00:33:32 PDT

Created attachment 227726 [details] patch Looking for a better/shorter name than "Active Descendant" especially since it doesn't have to be a descendant. Current patch is using the UI String "Focus Pointer" but I'm very open to suggestions if you think of something better.

James Craig

Comment 3 2014-03-25 00:47:49 PDT

Created attachment 227727 [details] screen shot Attached to so UI. Inspector is focused on the Facebook search combo box. Focus pointer (active descendant) hovered in the sidebar so the overlay is on the selected search suggestion. (Note one site author error is visible. The "Owns" pointer is a div with no defined role, when combobox expects @aria-owns to point to the listbox.)

James Craig

Comment 4 2014-03-25 01:01:47 PDT

s/Attached to so UI/Attached to show UI/

James Craig

Comment 5 2014-03-25 01:02:51 PDT

Potential UI String alternatives to "Focus Pointer": Focus Point, Acting Focus, Focus Proxy, Proxy Focus, Pseudo-Focus, Focus Redirect.

James Craig

Comment 6 2014-03-25 01:03:59 PDT

Acting Focus and Focus Proxy are my top choices atm.

Timothy Hatcher

Comment 7 2014-03-25 15:52:57 PDT

Comment on attachment 227726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=227726&action=review > Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:61 > + this._accessibilityNodeActiveDescendantRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Focus Pointer")); I think Active Descendant is fine, since it matches the ARIA wording.

James Craig

Comment 8 2014-03-25 18:44:27 PDT

Created attachment 227822 [details] patch New patch uses "Shared Focus" to match the desktop terminology.

WebKit Commit Bot

Comment 9 2014-03-25 20:04:06 PDT

Comment on attachment 227822 [details] patch Clearing flags on attachment: 227822 Committed r166279: <http://trac.webkit.org/changeset/166279>

WebKit Commit Bot

Comment 10 2014-03-25 20:04:10 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.