| Summary: | Web Inspector: AXI: add support for aria-activedescendant and reconcile UI/testing with parentNode | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | James Craig <jcraig> | ||||||||
| Component: | Web Inspector | Assignee: | James Craig <jcraig> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | All | ||||||||||
| OS: | All | ||||||||||
| Attachments: |
|
||||||||||
|
Description
James Craig
2014-03-25 00:22:08 PDT
Created attachment 227726 [details]
patch
Looking for a better/shorter name than "Active Descendant" especially since it doesn't have to be a descendant. Current patch is using the UI String "Focus Pointer" but I'm very open to suggestions if you think of something better.
Created attachment 227727 [details]
screen shot
Attached to so UI. Inspector is focused on the Facebook search combo box. Focus pointer (active descendant) hovered in the sidebar so the overlay is on the selected search suggestion.
(Note one site author error is visible. The "Owns" pointer is a div with no defined role, when combobox expects @aria-owns to point to the listbox.)
s/Attached to so UI/Attached to show UI/ Potential UI String alternatives to "Focus Pointer": Focus Point, Acting Focus, Focus Proxy, Proxy Focus, Pseudo-Focus, Focus Redirect. Acting Focus and Focus Proxy are my top choices atm. Comment on attachment 227726 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=227726&action=review > Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js:61 > + this._accessibilityNodeActiveDescendantRow = new WebInspector.DetailsSectionSimpleRow(WebInspector.UIString("Focus Pointer")); I think Active Descendant is fine, since it matches the ARIA wording. Created attachment 227822 [details]
patch
New patch uses "Shared Focus" to match the desktop terminology.
Comment on attachment 227822 [details] patch Clearing flags on attachment: 227822 Committed r166279: <http://trac.webkit.org/changeset/166279> All reviewed patches have been landed. Closing bug. |