Summary: | Web Inspector: reduce per-protocol method function creation in InspectorBackend | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | BJ Burg <bburg> | ||||||
Component: | Web Inspector | Assignee: | Brian Burg <burg> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | burg, commit-queue, graouts, joepeck, timothy, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | 528+ (Nightly build) | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
BJ Burg
2014-03-24 16:23:25 PDT
Created attachment 230415 [details]
the patch
Comment on attachment 230415 [details] the patch View in context: https://bugs.webkit.org/attachment.cgi?id=230415&action=review > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:246 > + var callable = function() { function callable() { > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:248 > + }; No ; > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:292 > + console.log("invoke args: ", args, "len: ", args.length); > + console.log("signature: ", JSON.stringify(instance._callSignature)); Debug? Or this.dumpInspectorProtocolMessages? > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:295 > + console.log("callback:", callback); Ditto. > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:310 > + console.log("processing arg " + i + ":", value); Ditto. > Source/WebInspectorUI/UserInterface/Protocol/InspectorBackend.js:313 > + if (optionalFlag && typeof value === "undefined") { > + continue; > + } No braces. Created attachment 230446 [details]
address review comments
Comment on attachment 230446 [details] address review comments Clearing flags on attachment: 230446 Committed r167984: <http://trac.webkit.org/changeset/167984> All reviewed patches have been landed. Closing bug. |