Bug 130697

Summary:

REGRESSION (r165872): Double-applying device scale to snapshots

Product:

WebKit

Reporter:

Tim Horton <thorton>

Component:

WebKit2

Assignee:

Tim Horton <thorton>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

andersca, conrad_shultz, simon.fraser

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
patch	simon.fraser: review+

Tim Horton

Reported 2014-03-24 15:20:49 PDT

I made a mistake in r165872 that caused us to apply the device scale twice when snapshotting via scaledSnapshotWithOptions. <rdar://problem/16396629>

Attachments
patch (3.73 KB, patch) 2014-03-24 15:43 PDT, Tim Horton	simon.fraser: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Tim Horton

Comment 1 2014-03-24 15:43:21 PDT

Created attachment 227697 [details] patch 1) We need snapshotting tests desperately, there are too many combinations of options to not have some tests. 2) I need to test WKThumbnailView before landing this.

Tim Horton

Comment 2 2014-03-24 16:14:59 PDT

http://trac.webkit.org/changeset/166203

Note You need to log in before you can comment on or make changes to this bug.