Bug 130687

Summary: prepare-ChangeLog fails for new files and throws errors for modified files.
Product: WebKit Reporter: Ion Rosca <rosca>
Component: Tools / TestsAssignee: László Langó <llango.u-szeged>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, darin, gyuyoung.kim, llango.u-szeged, lvidacs.u-szeged
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
output
none
Patch none

Description Ion Rosca 2014-03-24 11:03:36 PDT 
I have a CL with several new tests and several changes in renderer files.
The command line is:
./Tools/Scripts/prepare-ChangeLog -b 130664 -g HEAD^1..HEAD

I'm attaching the output file redirected from STDERR.
Comment 1 Ion Rosca 2014-03-24 11:04:30 PDT 
Created attachment 227669 [details]
output
Comment 2 Ion Rosca 2014-03-24 11:06:32 PDT 
It works after reverting this change: http://trac.webkit.org/changeset/166156
Comment 3 Ion Rosca 2014-03-25 00:01:23 PDT 
It works after http://trac.webkit.org/changeset/166189, but it still complains about a few things:

declaring a method but don't have interface on line 9 in Source/WebCore/rendering/RenderLayerCompositor.h

missing close braces in Source/WebCore/rendering/RenderLayerCompositor.h (probable start at 80)
mismatched parentheses in Source/WebCore/rendering/RenderLayerCompositor.h

declaring a method but don't have interface on line 9 in Source/WebCore/rendering/RenderLayerCompositor.cpp

missing close braces in Source/WebCore/rendering/RenderLayerCompositor.cpp (probable start at 80)
mismatched parentheses in Source/WebCore/rendering/RenderLayerCompositor.cpp
Comment 4 Ion Rosca 2014-03-25 00:15:47 PDT 
Here is the patch I was playing with on mac os x: https://bug-130664-attachments.webkit.org/attachment.cgi?id=227676
Perl version is v5.16.2 built for darwin-thread-multi-2level, with 3 registered patches.
Comment 5 László Langó 2014-03-25 02:38:52 PDT 
Created attachment 227730 [details]
Patch
Comment 6 WebKit Commit Bot 2014-03-25 08:54:06 PDT 
Comment on attachment 227730 [details]
Patch

Clearing flags on attachment: 227730

Committed r166235: <http://trac.webkit.org/changeset/166235>
Comment 7 WebKit Commit Bot 2014-03-25 08:54:12 PDT 
All reviewed patches have been landed.  Closing bug.