Bug 130682

Summary: REGRESSION(r166169): This patch broke tests on Apple Mavericks (Requested by fredw on #webkit).
Product: WebKit Reporter: WebKit Commit Bot <commit-queue>
Component: New BugsAssignee: WebKit Commit Bot <commit-queue>
Status: RESOLVED FIXED    
Severity: Normal CC: cfleizach, fred.wang
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 130572    
Attachments:
Description Flags
ROLLOUT of r166169 none

Description WebKit Commit Bot 2014-03-24 10:29:24 PDT
http://trac.webkit.org/changeset/166169 broke the build:
This patch broke tests on Apple Mavericks (Requested by fredw on #webkit).

This is an automatic bug report generated by webkitbot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests fail.
Comment 1 WebKit Commit Bot 2014-03-24 10:29:55 PDT
Created attachment 227664 [details]
ROLLOUT of r166169

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 WebKit Commit Bot 2014-03-24 10:32:14 PDT
Comment on attachment 227664 [details]
ROLLOUT of r166169

Rejecting attachment 227664 [details] from commit-queue.

fred.wang@free.fr does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json.

- If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags.

- If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed).  The commit-queue restarts itself every 2 hours.  After restart the commit-queue will correctly respect your committer rights.
Comment 3 Frédéric Wang (:fredw) 2014-03-24 10:39:38 PDT
Comment on attachment 227664 [details]
ROLLOUT of r166169

Clearing flags on attachment: 227664

Committed r166179: <http://trac.webkit.org/changeset/166179>
Comment 4 Frédéric Wang (:fredw) 2014-03-24 10:39:44 PDT
All reviewed patches have been landed.  Closing bug.