| Summary: | Merge Minor WebVTT Cleanups from Blink | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brent Fulgham <bfulgham> | ||||
| Component: | Media | Assignee: | Brent Fulgham <bfulgham> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj, webkit-bug-importer | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | 528+ (Nightly build) | ||||||
| Hardware: | All | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
Created attachment 227665 [details]
Patch
Comment on attachment 227665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227665&action=review > Source/WebCore/ChangeLog:7 > + https://bugs.webkit.org/show_bug.cgi?id=130681 > + > + Reviewed by NOBODY (OOPS!). > + You should reference the Blink bugs these changes are based on. Comment on attachment 227665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227665&action=review >> Source/WebCore/ChangeLog:7 >> + > > You should reference the Blink bugs these changes are based on. Doh! Committed r166180: <http://trac.webkit.org/changeset/166180> |
This bug merges the following two improvements in the WebVTT code: 1. Use TextTrackMode and TextTrackKind enums in TextTrack IDL Merged from Blink (patch by philipj@opera.com): https://chromium.googlesource.com/chromium/blink/+/693eb5e2933dca0eab5bbd604e9f3406fe9fd1ab http://crbug.com/52593009 2. Merge bools into bit fields in TextTrackCue and VTTCue Merged from Blink (patch by philipj@opera.com): https://chromium.googlesource.com/chromium/blink/+/40b3602feab34e9be829fd742b6ad6ded322a09f http://crbug.com/104243003