Bug 130681

Summary:

Merge Minor WebVTT Cleanups from Blink

Product:

WebKit

Reporter:

Brent Fulgham <bfulgham>

Component:

Media

Assignee:

Brent Fulgham <bfulgham>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, calvaris, cdumez, commit-queue, eric.carlson, esprehn+autocc, gyuyoung.kim, kondapallykalyan, philipj, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

Unspecified

Attachments:

Description	Flags
Patch	eric.carlson: review+

Brent Fulgham

Reported 2014-03-24 10:29:15 PDT

This bug merges the following two improvements in the WebVTT code: 1. Use TextTrackMode and TextTrackKind enums in TextTrack IDL Merged from Blink (patch by philipj@opera.com): https://chromium.googlesource.com/chromium/blink/+/693eb5e2933dca0eab5bbd604e9f3406fe9fd1ab http://crbug.com/52593009 2. Merge bools into bit fields in TextTrackCue and VTTCue Merged from Blink (patch by philipj@opera.com): https://chromium.googlesource.com/chromium/blink/+/40b3602feab34e9be829fd742b6ad6ded322a09f http://crbug.com/104243003

Attachments
Patch (4.94 KB, patch) 2014-03-24 10:31 PDT, Brent Fulgham	eric.carlson: review+	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-03-24 10:31:08 PDT

Brent Fulgham

Comment 2 2014-03-24 10:31:54 PDT

Eric Carlson

Comment 3 2014-03-24 10:35:22 PDT

Comment on attachment 227665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227665&action=review > Source/WebCore/ChangeLog:7 > + https://bugs.webkit.org/show_bug.cgi?id=130681 > + > + Reviewed by NOBODY (OOPS!). > + You should reference the Blink bugs these changes are based on.

Brent Fulgham

Comment 4 2014-03-24 10:38:18 PDT

Comment on attachment 227665 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227665&action=review >> Source/WebCore/ChangeLog:7 >> + > > You should reference the Blink bugs these changes are based on. Doh!

Brent Fulgham

Comment 5 2014-03-24 10:38:56 PDT

Note You need to log in before you can comment on or make changes to this bug.