| Summary: | Text autosizing does not determine line count correctly for simple line layout | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antti Koivisto <koivisto> | ||||||
| Component: | Layout and Rendering | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | commit-queue, dbates, ddkilzer, esprehn+autocc, glenn, kondapallykalyan | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | 528+ (Nightly build) | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Antti Koivisto
2014-03-24 09:09:12 PDT
Created attachment 227651 [details]
patch
Attachment 227651 [details] did not pass style-queue:
ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5]
Total errors found: 1 in 4 files
If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 227655 [details]
better patch
Comment on attachment 227655 [details] better patch View in context: https://bugs.webkit.org/attachment.cgi?id=227655&action=review > Source/WebCore/ChangeLog:8 > + We don't count lines correctly in simple line layout case. I'm unclear if we have DRT for iOS working. It would be great if we could write a test for this. |