Bug 130648

Summary: CREATE_DOM_WRAPPER doesn't need the ExecState.
Product: WebKit Reporter: Andreas Kling <kling>
Component: WebCore JavaScriptAssignee: Andreas Kling <kling>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, cdumez, cgarcia, commit-queue, eric.carlson, esprehn+autocc, glenn, jer.noble, jsbell, kangil.han, kling, philipj, sergio
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
darin: review+
Patch for landing none

Andreas Kling
Reported 2014-03-22 16:33:49 PDT
CREATE_DOM_WRAPPER doesn't need the JSC::ExecState. The global object should have everything we need.
Attachments
Patch (47.12 KB, patch)
2014-03-22 16:36 PDT, Andreas Kling 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (48.21 KB, patch)
2014-03-22 17:21 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2014-03-22 16:36:19 PDT
Created attachment 227578 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-22 16:37:57 PDT
Attachment 227578 [details] did not pass style-queue: ERROR: Source/WebCore/bindings/js/JSDOMBinding.h:211: Extra space after ( in function call [whitespace/parens] [4] Total errors found: 1 in 30 files If any of these errors are false positives, please file a bug against check-webkit-style.
Darin Adler
Comment 3 2014-03-22 16:42:34 PDT
Comment on attachment 227578 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227578&action=review > Source/WebCore/bindings/js/JSDOMBinding.h:211 > +template<class WrapperClass, class DOMClass> inline JSC::JSValue wrap( JSDOMGlobalObject* globalObject, DOMClass* domObject) Extra space left here before JSDOMGlobalObject
Andreas Kling
Comment 4 2014-03-22 17:21:27 PDT
Created attachment 227584 [details] Patch for landing
Andreas Kling
Comment 5 2014-03-22 17:35:52 PDT
Committed r166128: <http://trac.webkit.org/changeset/166128>
Note You need to log in before you can comment on or make changes to this bug.