Bug 130643 – Subpixel rendering: Transition class Image (and its dependencies) from int to float to enable subpixel positioned/sized images.

• Component: Layout and Rendering
• Status: RESOLVED FIXED

[alan]

This is in preparation to support subpixel (background)images.

[alan]

Created attachment 227565 [details]
Patch

[Build Bot]

Comment on attachment 227565 [details]
Patch

Attachment 227565 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/4898611695452160

New failing tests:
svg/filters/feImage-position.svg
svg/W3C-SVG-1.1/filters-displace-01-f.svg
svg/filters/feImage-subregions.svg
svg/custom/feDisplacementMap-01.svg
svg/filters/feImage-target-id-change.svg
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-multiple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-changes-id.svg
svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-remove-target.svg
fast/repaint/obscured-background-no-repaint.html
svg/filters/feImage-subregions-preseveAspectRatio-none.svg
svg/filters/feImage-target-add-to-document.svg
svg/W3C-SVG-1.1/filters-composite-02-b.svg
svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg
svg/W3C-SVG-1.1-SE/filters-image-03-f.svg
svg/filters/feImage-preserveAspectratio.svg
svg/filters/feImage-change-target-id.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg
svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg
svg/filters/feImage-preserveAspectRatio-all.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-reference-invalidation.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg

[Build Bot]

Created attachment 227572 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227565 [details]
Patch

Attachment 227565 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/4854492986081280

New failing tests:
svg/filters/feImage-position.svg
svg/W3C-SVG-1.1/filters-displace-01-f.svg
svg/filters/feImage-subregions.svg
svg/custom/feDisplacementMap-01.svg
svg/filters/feImage-target-id-change.svg
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-multiple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-changes-id.svg
svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-remove-target.svg
svg/filters/feImage-subregions-preseveAspectRatio-none.svg
svg/filters/feImage-target-add-to-document.svg
svg/W3C-SVG-1.1/filters-composite-02-b.svg
svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg
svg/W3C-SVG-1.1-SE/filters-image-03-f.svg
svg/filters/feImage-preserveAspectratio.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-change-target-id.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg
svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg
svg/filters/feImage-preserveAspectRatio-all.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-reference-invalidation.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg

[Build Bot]

Created attachment 227575 [details]
Archive of layout-test-results from webkit-ews-02 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-02  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[alan]

all output format diffs:
[feImage image-size="400x400"]
vs.
[feImage image-size="400.00x400.00"]

[Build Bot]

Comment on attachment 227565 [details]
Patch

Attachment 227565 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/6684080334700544

New failing tests:
svg/filters/feImage-position.svg
svg/W3C-SVG-1.1/filters-displace-01-f.svg
svg/filters/feImage-subregions.svg
svg/custom/feDisplacementMap-01.svg
svg/filters/feImage-target-id-change.svg
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
svg/filters/feImage-target-inline-style-change.svg
svg/filters/feImage-multiple-targets-id-change.svg
svg/filters/feImage-target-attribute-change-with-use-indirection.svg
svg/filters/feImage-target-changes-id.svg
svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-remove-target.svg
svg/filters/feImage-subregions-preseveAspectRatio-none.svg
svg/filters/feImage-target-add-to-document.svg
svg/W3C-SVG-1.1/filters-composite-02-b.svg
svg/filters/feImage-late-indirect-update.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg
svg/W3C-SVG-1.1-SE/filters-image-03-f.svg
svg/filters/feImage-preserveAspectratio.svg
svg/filters/feImage-target-property-change.svg
svg/filters/feImage-change-target-id.svg
svg/filters/feImage-target-attribute-change.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg
svg/filters/feImage-subregions-preseveAspectRatio-none-with-viewBox.svg
svg/filters/feImage-preserveAspectRatio-all.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-reference-invalidation.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg

[Build Bot]

Created attachment 227577 [details]
Archive of layout-test-results from webkit-ews-01 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-01  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[alan]

Created attachment 227580 [details]
Patch

[alan]

Created attachment 227585 [details]
Patch

[alan]

Created attachment 227586 [details]
Patch

[alan]

Created attachment 227590 [details]
Patch

[alan]

Created attachment 227592 [details]
Patch

[Build Bot]

Comment on attachment 227592 [details]
Patch

Attachment 227592 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/5089898532962304

New failing tests:
svg/W3C-SVG-1.1/filters-composite-02-b.svg
svg/W3C-SVG-1.1/filters-displace-01-f.svg
svg/filters/feImage-preserveAspectRatio-all.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/W3C-SVG-1.1-SE/filters-image-03-f.svg
svg/filters/feImage-preserveAspectratio.svg
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-subregions-preseveAspectRatio-none.svg

[Build Bot]

Created attachment 227599 [details]
Archive of layout-test-results from webkit-ews-14 for mac-mountainlion-wk2

The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-14  Port: mac-mountainlion-wk2  Platform: Mac OS X 10.8.5

[Build Bot]

Comment on attachment 227592 [details]
Patch

Attachment 227592 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/5651434905272320

New failing tests:
svg/W3C-SVG-1.1/filters-composite-02-b.svg
svg/W3C-SVG-1.1/filters-displace-01-f.svg
svg/filters/feImage-preserveAspectRatio-all.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse.svg
svg/W3C-SVG-1.1/filters-image-01-b.svg
svg/filters/feImage-reference-svg-primitive.svg
svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse.svg
svg/filters/feImage-target-attribute-change-with-use-indirection-2.svg
svg/W3C-SVG-1.1-SE/filters-image-03-f.svg
svg/filters/feImage-preserveAspectratio.svg
svg/W3C-SVG-1.1-SE/filters-image-05-f.svg
svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox.svg
svg/filters/feImage-subregions-preseveAspectRatio-none.svg

[Build Bot]

Created attachment 227600 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.5

[alan]

Created attachment 227601 [details]
Patch

[alan]

Created attachment 227602 [details]
Patch

[alan]

Created attachment 227604 [details]
Patch

[alan]

Created attachment 227607 [details]
Patch

[alan]

omg finally.

[alan]

Created attachment 227611 [details]
Patch

[alan]

Comment on attachment 227611 [details]
Patch

almost.

[alan]

yay

[Simon Fraser (smfr)]

Comment on attachment 227611 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=227611&action=review

> Source/WebCore/platform/graphics/IntPoint.cpp:43
> +IntPoint::IntPoint(const FloatPoint& p)
> +    : m_x(clampToInteger(p.x()))
> +    , m_y(clampToInteger(p.y()))
> +{
> +}

Shouldn't this be up next to the other constructors?

> Source/WebCore/platform/graphics/IntSize.cpp:43
> +IntSize::IntSize(const FloatSize& s)
> +    : m_width(clampToInteger(s.width()))
> +    , m_height(clampToInteger(s.height()))
> +{
> +}

Ditto.

> Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:128
> +    : m_data(IntSize(size)) // NOTE: The input here isn't important as ImageBufferDataCG's constructor just ignores it.

I wonder if we should have a IntSize expectedIntegeralSize(const FloatSize&) which asserts if not integral?

> LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:9
> +          [feImage image-size="100.00x100.00"]

Can't we just be smarter about dumping?

[alan]

(In reply to comment #26)
> (From update of attachment 227611 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227611&action=review
> 
> > Source/WebCore/platform/graphics/IntPoint.cpp:43
> > +IntPoint::IntPoint(const FloatPoint& p)
> > +    : m_x(clampToInteger(p.x()))
> > +    , m_y(clampToInteger(p.y()))
> > +{
> > +}
> 
> Shouldn't this be up next to the other constructors?
> 
> > Source/WebCore/platform/graphics/IntSize.cpp:43
> > +IntSize::IntSize(const FloatSize& s)
> > +    : m_width(clampToInteger(s.width()))
> > +    , m_height(clampToInteger(s.height()))
> > +{
> > +}
> 
> Ditto.
> 
Don't want to include Float* in the .h.

> > Source/WebCore/platform/graphics/cg/ImageBufferCG.cpp:128
> > +    : m_data(IntSize(size)) // NOTE: The input here isn't important as ImageBufferDataCG's constructor just ignores it.
> 
> I wonder if we should have a IntSize expectedIntegeralSize(const FloatSize&) which asserts if not integral?
> 
Good idea. I'll add that in an upcoming patch.

> > LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:9
> > +          [feImage image-size="100.00x100.00"]
> 
> Can't we just be smarter about dumping?
Yes and I have a bug on that. I think making that change should be in a separate patch. It requires rebaselining.

[alan]

Created attachment 228235 [details]
Patch

[alan]

Comment on attachment 228235 [details]
Patch

EWS

[WebKit Commit Bot]

Comment on attachment 228235 [details]
Patch

Clearing flags on attachment: 228235

Committed r166582: <http://trac.webkit.org/changeset/166582>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.