Bug 130635

Summary:

Web Inspector: AXI: add other ARIA one-to-many relationships: owns, flowto, controls.

Product:

WebKit

Reporter:

James Craig <jcraig>

Component:

Web Inspector

Assignee:

James Craig <jcraig>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, graouts, joepeck, timothy, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

528+ (Nightly build)

Hardware:

All

OS:

All

Attachments:

Description	Flags
patch	darin: review+
patch with review feedback	none

James Craig

Reported 2014-03-22 00:30:12 PDT

Web Inspector: AXI: add other ARIA one-to-many relationships: owns, flowto, controls. Not including labelledby or describedby b/c those will be computed values for label, etc.

Attachments
patch (24.99 KB, patch) 2014-03-22 01:26 PDT, James Craig	darin: review+	Details Formatted Diff Diff
patch with review feedback (24.99 KB, patch) 2014-03-22 17:05 PDT, James Craig	no flags	Details Formatted Diff Diff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.

Radar WebKit Bug Importer

Comment 1 2014-03-22 00:32:03 PDT

<rdar://problem/16398942>

James Craig

Comment 2 2014-03-22 01:26:29 PDT

Created attachment 227541 [details] patch

WebKit Commit Bot

Comment 3 2014-03-22 01:26:45 PDT

Comment on attachment 227541 [details] patch Rejecting attachment 227541 [details] from commit-queue. jcraig@apple.com does not have committer permissions according to http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitpy/common/config/contributors.json. - If you do not have committer rights please read http://webkit.org/coding/contributing.html for instructions on how to use bugzilla flags. - If you have committer rights please correct the error in Tools/Scripts/webkitpy/common/config/contributors.json by adding yourself to the file (no review needed). The commit-queue restarts itself every 2 hours. After restart the commit-queue will correctly respect your committer rights.

James Craig

Comment 4 2014-03-22 01:27:34 PDT

Must've flubbed the cq? to cq+

Darin Adler

Comment 5 2014-03-22 07:08:48 PDT

Comment on attachment 227541 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=227541&action=review > Source/WebCore/inspector/InspectorDOMAgent.cpp:1481 > + for (const auto& controlledElement : controlledElements) No need to say "const auto&" here. Just "auto&" or "auto*" is better. And "Element*" is shorter than "const auto&", so you could use that too. > Source/WebCore/inspector/InspectorDOMAgent.cpp:1498 > + for (const auto& flowedElement : flowedElements) Ditto. > Source/WebCore/inspector/InspectorDOMAgent.cpp:1528 > + for (const auto& ownedElement : ownedElements) Ditto.

James Craig

Comment 6 2014-03-22 17:05:26 PDT

Created attachment 227581 [details] patch with review feedback

WebKit Commit Bot

Comment 7 2014-03-23 10:32:40 PDT

Comment on attachment 227581 [details] patch with review feedback Clearing flags on attachment: 227581 Committed r166141: <http://trac.webkit.org/changeset/166141>

WebKit Commit Bot

Comment 8 2014-03-23 10:32:43 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.