Summary: | Would like the style bot to prohibit #include layering violations | ||
---|---|---|---|
Product: | WebKit | Reporter: | Geoffrey Garen <ggaren> |
Component: | Tools / Tests | Assignee: | Nobody <webkit-unassigned> |
Status: | NEW --- | ||
Severity: | Normal | CC: | ossy, simon.fraser, zan |
Priority: | P2 | Keywords: | InRadar |
Version: | 528+ (Nightly build) | ||
Hardware: | Unspecified | ||
OS: | Unspecified |
Description
Geoffrey Garen
2014-03-21 18:58:02 PDT
Should we start generating separate forwarding headers for the platform layer? Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations. (In reply to comment #2) > Cross-inclusion of <Platform/Header.h> in WebCore would be allowed at first, but it would extremely simplify locating these layering violations. I meant the other way around, that is including <WebCore/Header.h> in the platform layer. In my opinion if we could get rid include paths (as blink did it), it's obvious to catch layering violations by anybody without any sophisticated script and style checker. But unfortunately there were many objections against relative includes to Source. *** Bug 252858 has been marked as a duplicate of this bug. *** |