| Summary: | Don't flush compositing layers within FrameView::willPaintContents() | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Component: | New Bugs | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | bdakin, buildbot, rniwa, simon.fraser, thorton, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
Simon Fraser (smfr)
2014-03-21 18:32:27 PDT
Created attachment 227523 [details]
Patch
*** Bug 123753 has been marked as a duplicate of this bug. *** Comment on attachment 227523 [details] Patch Attachment 227523 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5167235324706816 New failing tests: media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html Created attachment 227525 [details]
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews.
Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Created attachment 227527 [details]
Patch
Comment on attachment 227527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227527&action=review > Source/WebKit/mac/ChangeLog:26 > +2014-03-21 Simon Fraser <simon.fraser@apple.com> > + > + Don't flush compositing layers within FrameView::willPaintContents() > + https://bugs.webkit.org/show_bug.cgi?id=130627 > + > + Reviewed by NOBODY (OOPS!). > + > + Make _flushCompositingChanges private so DRT can call it; > + moved it into the Private category. > + > + * WebView/WebView.mm: > + (-[WebView _flushCompositingChanges]): > + * WebView/WebViewPrivate.h: > + > +2014-03-21 Simon Fraser <simon.fraser@apple.com> > + > + Remove duplicate line added during merging > + https://bugs.webkit.org/show_bug.cgi?id=130623 > + > + Reviewed by Beth Dakin. > + > + Remove a duplicate call to -_viewWillDrawInternal which > + was added during merges. > + > + * WebView/WebView.mm: > + (LayerFlushController::flushLayers): Double ChangeLog! |