Bug 130627

Summary: Don't flush compositing layers within FrameView::willPaintContents()
Product: WebKit Reporter: Simon Fraser (smfr) <simon.fraser>
Component: New BugsAssignee: Simon Fraser (smfr) <simon.fraser>
Status: RESOLVED FIXED    
Severity: Normal CC: bdakin, buildbot, rniwa, simon.fraser, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2
none
Patch sam: review+

Simon Fraser (smfr)
Reported 2014-03-21 18:32:27 PDT
Don't flush compositing layers within FrameView::willPaintContents()
Attachments
Patch (9.97 KB, patch)
2014-03-21 18:51 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 (499.50 KB, application/zip)
2014-03-21 19:48 PDT, Build Bot 		no flags
Details
Patch (10.77 KB, patch)
2014-03-21 20:21 PDT, Simon Fraser (smfr) 		sam: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2014-03-21 18:51:40 PDT
Created attachment 227523 [details] Patch
Simon Fraser (smfr)
Comment 2 2014-03-21 18:52:17 PDT
*** Bug 123753 has been marked as a duplicate of this bug. ***
Simon Fraser (smfr)
Comment 3 2014-03-21 18:54:46 PDT
<rdar://problem/16368869>
Build Bot
Comment 4 2014-03-21 19:48:27 PDT
Comment on attachment 227523 [details] Patch Attachment 227523 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5167235324706816 New failing tests: media/W3C/audio/canPlayType/canPlayType_application_octet_stream.html
Build Bot
Comment 5 2014-03-21 19:48:30 PDT
Created attachment 227525 [details] Archive of layout-test-results from webkit-ews-15 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-15 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Simon Fraser (smfr)
Comment 6 2014-03-21 20:21:50 PDT
Created attachment 227527 [details] Patch
Sam Weinig
Comment 7 2014-03-22 10:47:52 PDT
Comment on attachment 227527 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227527&action=review > Source/WebKit/mac/ChangeLog:26 > +2014-03-21 Simon Fraser <simon.fraser@apple.com> > + > + Don't flush compositing layers within FrameView::willPaintContents() > + https://bugs.webkit.org/show_bug.cgi?id=130627 > + > + Reviewed by NOBODY (OOPS!). > + > + Make _flushCompositingChanges private so DRT can call it; > + moved it into the Private category. > + > + * WebView/WebView.mm: > + (-[WebView _flushCompositingChanges]): > + * WebView/WebViewPrivate.h: > + > +2014-03-21 Simon Fraser <simon.fraser@apple.com> > + > + Remove duplicate line added during merging > + https://bugs.webkit.org/show_bug.cgi?id=130623 > + > + Reviewed by Beth Dakin. > + > + Remove a duplicate call to -_viewWillDrawInternal which > + was added during merges. > + > + * WebView/WebView.mm: > + (LayerFlushController::flushLayers): Double ChangeLog!
Simon Fraser (smfr)
Comment 8 2014-03-22 10:53:02 PDT
https://trac.webkit.org/r166117
Note You need to log in before you can comment on or make changes to this bug.