Bug 130621

Summary: [iOS] clean up fullscreen player controller when exiting fullscreen
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Eric Carlson <eric.carlson>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, glenn, jer.noble, philipj, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Proposed patch. none

Eric Carlson
Reported 2014-03-21 15:52:29 PDT
The fullscreen video layer's WebAVPlayerController is retained by the player view controller and can outlive the layer, so clear the view controller's delegate and player controller when we exit from fullscreen.
Attachments
Proposed patch. (2.33 KB, patch)
2014-03-21 15:56 PDT, Eric Carlson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Eric Carlson
Comment 1 2014-03-21 15:56:34 PDT
Created attachment 227502 [details] Proposed patch.
Radar WebKit Bug Importer
Comment 2 2014-03-21 15:58:09 PDT
<rdar://problem/16396567>
Radar WebKit Bug Importer
Comment 3 2014-03-21 15:59:24 PDT
<rdar://problem/16396588>
Jer Noble
Comment 4 2014-03-21 16:07:28 PDT
Comment on attachment 227502 [details] Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=227502&action=review r=me with nits. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:207 > + if (_avPlayerController && [_avPlayerController delegate]) This should be unnecessary. If _avPlayerController is nil, [_avPlayerController delegate] will return nil as well. > Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm:215 > + if (!_avPlayerController || ![_avPlayerController delegate]) Ditto.
Eric Carlson
Comment 5 2014-03-21 16:20:28 PDT
Committed r166106: https://trac.webkit.org/r166106
Note You need to log in before you can comment on or make changes to this bug.