Bug 130619

Summary: REGRESSION (r165356): Predictive Chinese input is broken
Product: WebKit Reporter: Alexey Proskuryakov <ap>
Component: WebKit2Assignee: Alexey Proskuryakov <ap>
Status: RESOLVED FIXED    
Severity: Normal CC: andersca, darin, enrica
Priority: P1    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
proposed patch enrica: review+

Description Alexey Proskuryakov 2014-03-21 14:59:48 PDT 
Predictive Chinese input is very special - it doesn't have an inline input area, but critically depends on us calling -discardMarkedText at exactly the right times.

Changes in when editor state is updated resulted in us calling it too eagerly. Updating editor state was and remains hopelessly broken, thankfully, we will not depend on it as much with async input.

Steps to reproduce:
1. Enable Cangjie input.
2. Type "sina"
3. Press "1" several times.

Expected results: each time "1" is pressed, something is inserted, and a new suggestion popup appears.
Actual results: After the first time, there is no suggestion popup.
Comment 1 Alexey Proskuryakov 2014-03-21 15:02:39 PDT 
Created attachment 227495 [details]
proposed patch
Comment 2 Enrica Casucci 2014-03-21 15:54:05 PDT 
Comment on attachment 227495 [details]
proposed patch

Looks good.
Comment 3 Alexey Proskuryakov 2014-03-21 15:59:07 PDT 
Committed <http://trac.webkit.org/r166105>.