Bug 130616

Summary: Merge VTTScanner Code
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, bunhere, calvaris, commit-queue, eric.carlson, esprehn+autocc, gyuyoung.kim, philipj, rakuco, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch eric.carlson: review+

Brent Fulgham
Reported 2014-03-21 14:00:50 PDT
This patch merges the VTTScanner implementation from Blink to WebKit: 1. Introduce VTTScanner - a parser helper for various VTT parsing needs https://chromium.googlesource.com/chromium/blink/+/f1ceb058d574a1174b524c57f67350510a942071 http://crbug.com/75273002 fs@opera.com 2. Remove position argument from VTTParser::collectTimeStamp https://chromium.googlesource.com/chromium/blink/+/3e2c67969486e86347b328c72c67cacabfe6f4a1 http://crbug.com/134173002 fs@opera.com 3. Use VTTScanner for VTT cue settings parsing https://chromium.googlesource.com/chromium/blink/+/5962b7bbb001838f3fc7f24817637528b86bfd9b http://crbug.com/134153002 fs@opera.com 4. Use VTTScanner for VTT region settings parsing https://chromium.googlesource.com/chromium/blink/+/6c81f51438013edca920a19fc6a31026fc562af2 http://crbug.com/137033002 fs@opera.com 5. Make VTTRegion::setRegionSettings use VTTScanner https://chromium.googlesource.com/chromium/blink/+/fa286dca17a291da3ae8be80111e2264de6d5cfd http://crbug.com/140503004 fs@opera.com 6. Rework float value/percentage scanning for VTTRegion https://chromium.googlesource.com/chromium/blink/+/8f33b63aabcce7dd21dd15288d45c4eb37c02001 http://crbug.com/139343006 fs@opera.com 7. Rework end-of-value field handling in VTTRegion::parseSettingValue https://chromium.googlesource.com/chromium/blink/+/1872b54b908fac525f1ad9d6f15174b11e27c8af http://crbug.com/143983002 fs@opera.com 8. Pass a VTTScanner to VTTRegion::parseSettingValue https://chromium.googlesource.com/chromium/blink/+/e6494b3359e2077bd8772d86ab1fb709acf4c398 http://crbug.com/144893002 fs@opera.com
Attachments
Patch (64.73 KB, patch)
2014-03-21 14:09 PDT, Brent Fulgham 		eric.carlson: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-03-21 14:01:50 PDT
<rdar://problem/16394988>
Brent Fulgham
Comment 2 2014-03-21 14:09:46 PDT
Created attachment 227489 [details] Patch
Brent Fulgham
Comment 3 2014-03-21 14:27:14 PDT
Committed r166097: <http://trac.webkit.org/changeset/166097>
Note You need to log in before you can comment on or make changes to this bug.