Bug 130612

Summary:

Replace deprecatedIsCollapsibleWhitespace with RenderStyle::isCollapsibleWhiteSpace in TextIterator

Product:

WebKit

Reporter:

Chang Shu <cshu>

Component:

HTML Editing

Assignee:

Chang Shu <cshu>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

buildbot, commit-queue, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
fix patch	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2	none
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion	none
more tests need rebase	buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion	none
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2	none
fix patch	none

Chang Shu

Reported 2014-03-21 12:03:02 PDT

RenderStyle::isCollapsibleWhiteSpace is more accurate on determine a whitespace is collapsible.

Attachments
fix patch (6.46 KB, patch) 2014-03-21 12:07 PDT, Chang Shu	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 (618.18 KB, application/zip) 2014-03-21 12:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (625.94 KB, application/zip) 2014-03-21 13:19 PDT, Build Bot	no flags	Details
more tests need rebase (16.77 KB, patch) 2014-03-21 14:12 PDT, Chang Shu	buildbot: commit-queue-	Details Formatted Diff Diff
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (491.49 KB, application/zip) 2014-03-21 15:37 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-03 for mac-mountainlion (548.15 KB, application/zip) 2014-03-21 16:09 PDT, Build Bot	no flags	Details
Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 (464.77 KB, application/zip) 2014-03-21 16:13 PDT, Build Bot	no flags	Details
fix patch (17.36 KB, patch) 2014-03-22 17:36 PDT, Chang Shu	no flags	Details Formatted Diff Diff
Show Obsolete (7) View All Add attachment proposed patch, testcase, etc.

Chang Shu

Comment 1 2014-03-21 12:07:07 PDT

Created attachment 227468 [details] fix patch

Build Bot

Comment 2 2014-03-21 12:37:00 PDT

Comment on attachment 227468 [details] fix patch Attachment 227468 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/4676147153469440 New failing tests: fast/html/object-border.html fast/xsl/mozilla-tests.xml fast/table/cell-in-row-before-misnested-text-crash.xhtml fast/dom/Element/offsetTop-table-cell.html platform/mac/accessibility/table-multi-bodies.html fast/tokenizer/script_extra_close.html platform/mac/accessibility/aria-grid-with-strange-hierarchy.html accessibility/table-scope.html fast/table/cell-in-row-before-misnested-text-crash-css.html

Build Bot

Comment 3 2014-03-21 12:37:02 PDT

Created attachment 227471 [details] Archive of layout-test-results from webkit-ews-13 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-13 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Build Bot

Comment 4 2014-03-21 13:19:19 PDT

Comment on attachment 227468 [details] fix patch Attachment 227468 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5110843209416704 New failing tests: fast/html/object-border.html fast/xsl/mozilla-tests.xml fast/table/cell-in-row-before-misnested-text-crash.xhtml fast/table/cell-in-row-before-misnested-text-crash-css.html platform/mac/accessibility/table-multi-bodies.html fast/tokenizer/script_extra_close.html platform/mac/accessibility/aria-grid-with-strange-hierarchy.html accessibility/table-scope.html fast/dom/Element/offsetTop-table-cell.html

Build Bot

Comment 5 2014-03-21 13:19:22 PDT

Created attachment 227478 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Chang Shu

Comment 6 2014-03-21 14:12:33 PDT

Created attachment 227490 [details] more tests need rebase

Build Bot

Comment 7 2014-03-21 15:37:51 PDT

Comment on attachment 227490 [details] more tests need rebase Attachment 227490 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/4970658966536192 New failing tests: fast/dom/Element/offsetTop-table-cell.html

Build Bot

Comment 8 2014-03-21 15:37:54 PDT

Created attachment 227500 [details] Archive of layout-test-results from webkit-ews-04 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-04 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 9 2014-03-21 16:09:49 PDT

Comment on attachment 227490 [details] more tests need rebase Attachment 227490 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/6274439238909952 New failing tests: fast/dom/Element/offsetTop-table-cell.html

Build Bot

Comment 10 2014-03-21 16:09:52 PDT

Created attachment 227505 [details] Archive of layout-test-results from webkit-ews-03 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-03 Port: mac-mountainlion Platform: Mac OS X 10.8.5

Build Bot

Comment 11 2014-03-21 16:13:04 PDT

Comment on attachment 227490 [details] more tests need rebase Attachment 227490 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/6241316451123200 New failing tests: fast/dom/Element/offsetTop-table-cell.html

Build Bot

Comment 12 2014-03-21 16:13:07 PDT

Created attachment 227506 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5

Chang Shu

Comment 13 2014-03-22 17:36:02 PDT

Created attachment 227587 [details] fix patch

Darin Adler

Comment 14 2014-03-22 17:46:50 PDT

Comment on attachment 227587 [details] fix patch Does this get rid of all deprecatedIsCollapsibleWhitespace? Or are we still stuck with it in some places? Great change! Please land only if all tests pass, so lets wait for EWS.

Chang Shu

Comment 15 2014-03-22 18:54:12 PDT

(In reply to comment #14) > (From update of attachment 227587 [details]) > Does this get rid of all deprecatedIsCollapsibleWhitespace? Or are we still stuck with it in some places? > > Great change! Please land only if all tests pass, so lets wait for EWS. Thanks, Darin. The patch only removes all instances in TextIterator. There are still a few in other files like Position.cpp. I didn't remove all of them in one shot as I was afraid the regressions would be too much and I wasn't able to tell if some of them could be real problem. I will try to clean up all of them in the next patch.

WebKit Commit Bot

Comment 16 2014-03-22 19:44:20 PDT

Comment on attachment 227587 [details] fix patch Clearing flags on attachment: 227587 Committed r166134: <http://trac.webkit.org/changeset/166134>

WebKit Commit Bot

Comment 17 2014-03-22 19:44:24 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.