Bug 130609

Summary:

fix-blink-commit: new script to fix up renamed directory paths

Product:

WebKit

Reporter:

David Kilzer (:ddkilzer) <ddkilzer>

Component:

Tools / Tests

Assignee:

David Kilzer (:ddkilzer) <ddkilzer>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, commit-queue, darin, rniwa

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	none

David Kilzer (:ddkilzer)

Reported 2014-03-21 10:56:20 PDT

I created a tiny tool that just fixes up Blink directory paths in patches so they match back up with WebKit. We could add class renames to this as well if we find it useful. Nominal use: cat blink.patch | fix-blink-patch | svn-apply

Attachments
Patch v1 (2.83 KB, patch) 2014-03-21 11:11 PDT, David Kilzer (:ddkilzer)	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

David Kilzer (:ddkilzer)

Comment 1 2014-03-21 11:09:49 PDT

Hmm, I wonder if adding a "--blink" switch to svn-apply would be better: cat blink.patch | svn-apply --blink

David Kilzer (:ddkilzer)

Comment 2 2014-03-21 11:11:15 PDT

Created attachment 227462 [details] Patch v1

David Kilzer (:ddkilzer)

Comment 3 2014-03-21 11:21:21 PDT

(In reply to comment #1) > Hmm, I wonder if adding a "--blink" switch to svn-apply would be better: > > cat blink.patch | svn-apply --blink I think I want to hold off on this for now since svn-apply doesn't parse the patches itself--it calls parsePatch() in VCSUtils.pm, so there isn't a clear place to do it in svn-apply.

WebKit Commit Bot

Comment 4 2014-03-21 11:56:51 PDT

Comment on attachment 227462 [details] Patch v1 Clearing flags on attachment: 227462 Committed r166081: <http://trac.webkit.org/changeset/166081>

WebKit Commit Bot

Comment 5 2014-03-21 11:56:54 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.