| Summary: | Subpixel rendering: Make <img> positioning subpixel aware. | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue, d-r, esprehn+autocc, glenn, kondapallykalyan, rmondello, simon.fraser | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
|
Description
zalan
2014-03-21 09:05:08 PDT
patch is coming up. Created attachment 227467 [details]
Patch
Comment on attachment 227467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227467&action=review > Source/WebCore/platform/graphics/GraphicsContext.cpp:562 > + drawImage(image, styleColorSpace, FloatRect(p, FloatSize(image->size())), FloatRect(FloatPoint(), FloatSize(image->size())), op, description); Doesn't implicit IntSize -> FloatSize conversion happen? (In reply to comment #3) > (From update of attachment 227467 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227467&action=review > > > Source/WebCore/platform/graphics/GraphicsContext.cpp:562 > > + drawImage(image, styleColorSpace, FloatRect(p, FloatSize(image->size())), FloatRect(FloatPoint(), FloatSize(image->size())), op, description); > > Doesn't implicit IntSize -> FloatSize conversion happen? yes, it happens. I had that first but changed to explicit conversion. I guess it does not really bring any value, so I'll change it back to implicit. Created attachment 227472 [details]
Patch
Comment on attachment 227472 [details] Patch Rejecting attachment 227472 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 227472, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/4758999488528384 Created attachment 227492 [details]
Patch
Comment on attachment 227492 [details] Patch Clearing flags on attachment: 227492 Committed r166100: <http://trac.webkit.org/changeset/166100> All reviewed patches have been landed. Closing bug. |