Bug 130596

Summary: Subpixel rendering: Make <img> positioning subpixel aware.
Product: WebKit Reporter: alan <zalan>
Component: Layout and RenderingAssignee: alan <zalan>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue, d-r, esprehn+autocc, glenn, kondapallykalyan, rmondello, simon.fraser
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

alan
Reported 2014-03-21 09:05:08 PDT
+ this also enables proper hairline bordering for <img>
Attachments
Patch (20.46 KB, patch)
2014-03-21 11:50 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.73 KB, patch)
2014-03-21 12:37 PDT, alan 		no flags
DetailsFormatted DiffDiff
Patch (21.71 KB, patch)
2014-03-21 14:32 PDT, alan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
alan
Comment 1 2014-03-21 09:05:20 PDT
patch is coming up.
alan
Comment 2 2014-03-21 11:50:24 PDT
Created attachment 227467 [details] Patch
Simon Fraser (smfr)
Comment 3 2014-03-21 12:05:24 PDT
Comment on attachment 227467 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227467&action=review > Source/WebCore/platform/graphics/GraphicsContext.cpp:562 > + drawImage(image, styleColorSpace, FloatRect(p, FloatSize(image->size())), FloatRect(FloatPoint(), FloatSize(image->size())), op, description); Doesn't implicit IntSize -> FloatSize conversion happen?
alan
Comment 4 2014-03-21 12:28:47 PDT
(In reply to comment #3) > (From update of attachment 227467 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227467&action=review > > > Source/WebCore/platform/graphics/GraphicsContext.cpp:562 > > + drawImage(image, styleColorSpace, FloatRect(p, FloatSize(image->size())), FloatRect(FloatPoint(), FloatSize(image->size())), op, description); > > Doesn't implicit IntSize -> FloatSize conversion happen? yes, it happens. I had that first but changed to explicit conversion. I guess it does not really bring any value, so I'll change it back to implicit.
alan
Comment 5 2014-03-21 12:37:52 PDT
Created attachment 227472 [details] Patch
WebKit Commit Bot
Comment 6 2014-03-21 14:26:24 PDT
Comment on attachment 227472 [details] Patch Rejecting attachment 227472 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'validate-changelog', '--check-oops', '--non-interactive', 227472, '--port=mac']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit ChangeLog entry in LayoutTests/ChangeLog contains OOPS!. Full output: http://webkit-queues.appspot.com/results/4758999488528384
alan
Comment 7 2014-03-21 14:32:50 PDT
Created attachment 227492 [details] Patch
WebKit Commit Bot
Comment 8 2014-03-21 15:09:33 PDT
Comment on attachment 227492 [details] Patch Clearing flags on attachment: 227492 Committed r166100: <http://trac.webkit.org/changeset/166100>
WebKit Commit Bot
Comment 9 2014-03-21 15:09:39 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.