Bug 130592

Summary:

[EFL] Add expectations for flaky svg layout test

Product:

WebKit

Reporter:

Andrzej Badowski <a.badowski>

Component:

WebKit EFL

Assignee:

Nobody <webkit-unassigned>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

commit-queue, lucas.de.marchi

Priority:

Version:

528+ (Nightly build)

Hardware:

OS:

Linux

Attachments:

Description	Flags
proposed patch	none
proposed patch 2	none
proposed patch 3	commit-queue: commit-queue-
proposed patch 4	none

Andrzej Badowski

Reported 2014-03-21 07:22:10 PDT

Add expectations for flaky svg layout test

Attachments
proposed patch (1.36 KB, patch) 2014-03-21 07:35 PDT, Andrzej Badowski	no flags	Details Formatted Diff Diff
proposed patch 2 (3.55 KB, text/plain) 2014-03-21 09:20 PDT, Andrzej Badowski	no flags	Details
proposed patch 3 (2.98 KB, patch) 2014-03-24 02:57 PDT, Andrzej Badowski	commit-queue: commit-queue-	Details Formatted Diff Diff
proposed patch 4 (1.15 KB, patch) 2014-08-27 04:58 PDT, Andrzej Badowski	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Andrzej Badowski

Comment 1 2014-03-21 07:35:18 PDT

Created attachment 227434 [details] proposed patch

Andrzej Badowski

Comment 2 2014-03-21 09:20:59 PDT

Created attachment 227444 [details] proposed patch 2

Jinwoo Song

Comment 3 2014-03-21 19:03:39 PDT

Comment on attachment 227444 [details] proposed patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=227444&action=review > LayoutTests/platform/efl-wk2/TestExpectations:-290 > -Bug(EFL) fast/events/touch/basic-single-touch-events.html [ Failure ] You'd better to remove below line as setTouchPointRadius() is not implemented in EFL port. webkit.org/b/128906 fast/events/touch/basic-single-touch-events.html [ Crash ]

Andrzej Badowski

Comment 4 2014-03-24 02:57:01 PDT

Created attachment 227635 [details] proposed patch 3

WebKit Commit Bot

Comment 5 2014-03-24 07:02:19 PDT

Comment on attachment 227635 [details] proposed patch 3 Rejecting attachment 227635 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 227635, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl-wk2/TestExpectations Hunk #1 succeeded at 294 (offset 8 lines). Hunk #2 FAILED at 425. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl-wk2/TestExpectations.rej patching file LayoutTests/platform/efl/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5071289781846016

Andrzej Badowski

Comment 6 2014-08-27 04:44:25 PDT

1) fast/events/touch/basic-single-touch-events.html : My original proposal of 2014-03-24, ie. expected result PASS is already out of date. The current status of the FAIL is consistent with the history of the test. My suggestion is out of date. 2) http/tests/websocket/tests/hybi/workers/close.html : Currently expected result is consistent with those obtained results (PASS). My suggestion is already implemented (r166164, id134245, id136100) 3) svg/dom/svg-root/lengths.html My suggestion is still valid for this test.

Andrzej Badowski

Comment 7 2014-08-27 04:58:01 PDT

Created attachment 237219 [details] proposed patch 4

WebKit Commit Bot

Comment 8 2014-08-27 05:40:30 PDT

Comment on attachment 237219 [details] proposed patch 4 Clearing flags on attachment: 237219 Committed r173002: <http://trac.webkit.org/changeset/173002>

WebKit Commit Bot

Comment 9 2014-08-27 05:40:33 PDT

All reviewed patches have been landed. Closing bug.

Note You need to log in before you can comment on or make changes to this bug.