| Summary: | [EFL] Add expectations for flaky svg layout test | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Andrzej Badowski <a.badowski> | ||||||||||
| Component: | WebKit EFL | Assignee: | Nobody <webkit-unassigned> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | commit-queue, lucas.de.marchi | ||||||||||
| Priority: | P2 | ||||||||||||
| Version: | 528+ (Nightly build) | ||||||||||||
| Hardware: | PC | ||||||||||||
| OS: | Linux | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Andrzej Badowski
2014-03-21 07:22:10 PDT
Created attachment 227434 [details]
proposed patch
Created attachment 227444 [details]
proposed patch 2
Comment on attachment 227444 [details] proposed patch 2 View in context: https://bugs.webkit.org/attachment.cgi?id=227444&action=review > LayoutTests/platform/efl-wk2/TestExpectations:-290 > -Bug(EFL) fast/events/touch/basic-single-touch-events.html [ Failure ] You'd better to remove below line as setTouchPointRadius() is not implemented in EFL port. webkit.org/b/128906 fast/events/touch/basic-single-touch-events.html [ Crash ] Created attachment 227635 [details]
proposed patch 3
Comment on attachment 227635 [details] proposed patch 3 Rejecting attachment 227635 [details] from commit-queue. Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'apply-attachment', '--no-update', '--non-interactive', 227635, '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit Last 500 characters of output: from patch file(s). patching file LayoutTests/ChangeLog Hunk #1 succeeded at 1 with fuzz 3. patching file LayoutTests/platform/efl-wk2/TestExpectations Hunk #1 succeeded at 294 (offset 8 lines). Hunk #2 FAILED at 425. 1 out of 2 hunks FAILED -- saving rejects to file LayoutTests/platform/efl-wk2/TestExpectations.rej patching file LayoutTests/platform/efl/TestExpectations Failed to run "[u'/Volumes/Data/EWS/WebKit/Tools/Scripts/svn-apply', '--force']" exit_code: 1 cwd: /Volumes/Data/EWS/WebKit Full output: http://webkit-queues.appspot.com/results/5071289781846016 1) fast/events/touch/basic-single-touch-events.html : My original proposal of 2014-03-24, ie. expected result PASS is already out of date. The current status of the FAIL is consistent with the history of the test. My suggestion is out of date. 2) http/tests/websocket/tests/hybi/workers/close.html : Currently expected result is consistent with those obtained results (PASS). My suggestion is already implemented (r166164, id134245, id136100) 3) svg/dom/svg-root/lengths.html My suggestion is still valid for this test. Created attachment 237219 [details]
proposed patch 4
Comment on attachment 237219 [details] proposed patch 4 Clearing flags on attachment: 237219 Committed r173002: <http://trac.webkit.org/changeset/173002> All reviewed patches have been landed. Closing bug. |