Summary: | [CSS Regions] The background of children of scrollable elements flowed into regions is not properly scrolled | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Radu Stavila <stavila> | ||||||||||
Component: | CSS | Assignee: | Radu Stavila <stavila> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | commit-queue, esprehn+autocc, glenn, kondapallykalyan, WebkitBugTracker | ||||||||||
Priority: | P2 | Keywords: | AdobeTracked | ||||||||||
Version: | 528+ (Nightly build) | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Bug Depends on: | |||||||||||||
Bug Blocks: | 57312 | ||||||||||||
Attachments: |
|
Created attachment 227432 [details]
Patch
Created attachment 227433 [details]
Patch
Comment on attachment 227433 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227433&action=review > Source/WebCore/rendering/RenderNamedFlowThread.cpp:307 > + // Take the scrolled offset of this object's parents into consideration. > + IntSize scrolledContentOffset; > + RenderElement* parent = box.parent(); > + while (parent) { > + if (parent->isBox()) { > + RenderBox* parentBox = toRenderBox(parent); > + if (parentBox->isRenderNamedFlowThread()) { Don't we have a function to get the enclosing named flow thread for a box? Pretty sure we do, in which case writing this loop yourself seems like extra code? Created attachment 227443 [details]
Patch integrating feedback
Comment on attachment 227443 [details]
Patch integrating feedback
r=me
Comment on attachment 227443 [details] Patch integrating feedback Clearing flags on attachment: 227443 Committed r166259: <http://trac.webkit.org/changeset/166259> All reviewed patches have been landed. Closing bug. |
Created attachment 227406 [details] Test-case The background of children of elements flowed into scrollable regions is not properly scrolled. See attached test-case.