Bug 130565

Summary: Merge WebVTT Tokenizer Updates
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: MediaAssignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, buildbot, calvaris, commit-queue, eric.carlson, esprehn+autocc, glenn, gyuyoung.kim, jer.noble, philipj, rniwa, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
eric.carlson: review+, buildbot: commit-queue-
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
none
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 none

Brent Fulgham
Reported 2014-03-20 22:30:45 PDT
Merge a number of WebVTT Tokenizer fixes and improvements from Blink: 1. Simplify state handling in WebVTTTokenizer::nextToken 923db263aa65d6efd71c5b55708ad7eea6b23f53 https://codereview.chromium.org/73813002 fs@opera.com 2. Defer setting type in the WebVTT tokenizer until emitting the token 48375b1d56b2d8850ae93a6c6fb01c69fae82c75 https://codereview.chromium.org/77553004 fs@opera.com 3. Remove state-specific appendTo*/begin* methods from VTTToken 98d4fc4f5cb716a31d11907120b10538d4ba0f09 https://codereview.chromium.org/78833002 fs@opera.com 4. Turn VTTToken into an immutable object 0e53d4f9f140e979b7f32de495551684bc7f4cd2 https://codereview.chromium.org/81113003 fs@opera.com 5. Fix corner-cases for WebVTT tokenizer escape handling 730ef1e7f9a1919964f7e74e7ccb2f343e10a148 https://codereview.chromium.org/97103002 fs@opera.com 6. Cleanups for VTTTokenizer c373ee914ffabeaf833939129538251d8f2f4eca https://codereview.chromium.org/98763004 fs@opera.com 7. Split out common parsing code for Position/Size VTT cue settings 4ddb4d57948228fa05e49e06bd58a1179c09f212 https://codereview.chromium.org/118263002 fs@opera.com
Attachments
Patch (40.74 KB, patch)
2014-03-20 22:38 PDT, Brent Fulgham 		eric.carlson: review+
buildbot: commit-queue-
DetailsFormatted DiffDiff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (650.14 KB, application/zip)
2014-03-20 23:14 PDT, Build Bot 		no flags
Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (513.92 KB, application/zip)
2014-03-20 23:42 PDT, Build Bot 		no flags
Details
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2014-03-20 22:31:33 PDT
<rdar://problem/16388178>
Brent Fulgham
Comment 2 2014-03-20 22:38:57 PDT
Created attachment 227385 [details] Patch
Build Bot
Comment 3 2014-03-20 23:14:54 PDT
Comment on attachment 227385 [details] Patch Attachment 227385 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/5683276450627584 New failing tests: media/track/regions-webvtt/vtt-region-list.html media/track/regions-webvtt/vtt-region-dom-layout.html media/track/regions-webvtt/vtt-region-constructor.html media/track/regions-webvtt/text-track-cue-region-attribute.html media/track/regions-webvtt/vtt-region-display.html media/track/regions-webvtt/vtt-region-parser.html http/tests/media/track/track-webvtt-slow-loading.html
Build Bot
Comment 4 2014-03-20 23:14:59 PDT
Created attachment 227386 [details] Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.5
Build Bot
Comment 5 2014-03-20 23:42:26 PDT
Comment on attachment 227385 [details] Patch Attachment 227385 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/5954750327554048 New failing tests: media/track/regions-webvtt/vtt-region-list.html media/track/regions-webvtt/vtt-region-dom-layout.html media/track/regions-webvtt/vtt-region-constructor.html media/track/regions-webvtt/text-track-cue-region-attribute.html media/track/regions-webvtt/vtt-region-display.html media/track/regions-webvtt/vtt-region-parser.html
Build Bot
Comment 6 2014-03-20 23:42:30 PDT
Created attachment 227387 [details] Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-11 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.5
Brent Fulgham
Comment 7 2014-03-20 23:58:35 PDT
Comment on attachment 227385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227385&action=review > LayoutTests/TestExpectations:15 > +#webkit.org/b/109570 media/track/regions-webvtt [ Skip ] Obviously, this should not be checked in!
Brent Fulgham
Comment 8 2014-03-21 09:31:54 PDT
Committed r166066: <http://trac.webkit.org/changeset/166066>
Note You need to log in before you can comment on or make changes to this bug.