Summary: | WindowFeatures.{x|y|width|height} are not initialized | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Component: | DOM | Assignee: | David Kilzer (:ddkilzer) <ddkilzer> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | commit-queue | ||||
Priority: | P2 | Keywords: | BlinkMergeCandidate, InRadar | ||||
Version: | 528+ (Nightly build) | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Attachments: |
|
Description
David Kilzer (:ddkilzer)
2014-03-20 17:11:57 PDT
Created attachment 227436 [details]
Patch v1
Comment on attachment 227436 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review I’m saying review+ but this change doesn’t seem to have much benefit. > Source/WebCore/ChangeLog:13 > + - Initialize x, y, width, height in String constructor. Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug? (In reply to comment #3) > (From update of attachment 227436 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review > > I’m saying review+ but this change doesn’t seem to have much benefit. > > > Source/WebCore/ChangeLog:13 > > + - Initialize x, y, width, height in String constructor. > > Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug? It's to make code analysis tools happy. Comment on attachment 227436 [details] Patch v1 Clearing flags on attachment: 227436 Committed r166072: <http://trac.webkit.org/changeset/166072> All reviewed patches have been landed. Closing bug. |