Bug 130547 – WindowFeatures.{x|y|width|height} are not initialized

• Component: DOM
• Status: RESOLVED FIXED

[David Kilzer (:ddkilzer)]

Uninit Error reported from write at IPC::Channel::ChannelImpl::ProcessOutgoingMessages <https://code.google.com/p/chromium/issues/detail?id=342591>

Code Review:  <https://codereview.chromium.org/177633011/>

[David Kilzer (:ddkilzer)]

<rdar://problem/16383151>

[David Kilzer (:ddkilzer)]

Created attachment 227436 [details]
Patch v1

[Darin Adler]

Comment on attachment 227436 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review

I’m saying review+ but this change doesn’t seem to have much benefit.

> Source/WebCore/ChangeLog:13
> +        - Initialize x, y, width, height in String constructor.

Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug?

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 227436 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=227436&action=review
> 
> I’m saying review+ but this change doesn’t seem to have much benefit.
> 
> > Source/WebCore/ChangeLog:13
> > +        - Initialize x, y, width, height in String constructor.
> 
> Why? To make automated code analysis tools happy? To actually fix a bug? Where’s the test case for the bug?

It's to make code analysis tools happy.

[WebKit Commit Bot]

Comment on attachment 227436 [details]
Patch v1

Clearing flags on attachment: 227436

Committed r166072: <http://trac.webkit.org/changeset/166072>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.