Bug 130528

Summary: [WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2
Product: WebKit Reporter: Sam Weinig <sam>
Component: New BugsAssignee: Sam Weinig <sam>
Status: RESOLVED FIXED    
Severity: Normal CC: commit-queue
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 130551    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch
none
Patch thorton: review+

Sam Weinig
Reported 2014-03-20 12:28:28 PDT
[WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2
Attachments
Patch (4.69 KB, patch)
2014-03-20 12:29 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (12.73 KB, patch)
2014-03-21 14:03 PDT, Sam Weinig 		no flags
DetailsFormatted DiffDiff
Patch (13.39 KB, patch)
2014-03-21 15:32 PDT, Sam Weinig 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2014-03-20 12:29:27 PDT
Created attachment 227318 [details] Patch
Anders Carlsson
Comment 2 2014-03-20 12:30:38 PDT
Comment on attachment 227318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227318&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38 > +#if defined(__has_include) && __has_include(<xpc/private.h>) No need for #if defined(__has_include).
Sam Weinig
Comment 3 2014-03-20 12:33:14 PDT
Committed r165985: <http://trac.webkit.org/changeset/165985>
WebKit Commit Bot
Comment 4 2014-03-20 17:54:04 PDT
Re-opened since this is blocked by bug 130551
Sam Weinig
Comment 5 2014-03-21 14:03:24 PDT
Created attachment 227487 [details] Patch
Sam Weinig
Comment 6 2014-03-21 15:32:22 PDT
Created attachment 227499 [details] Patch
Tim Horton
Comment 7 2014-03-21 15:34:07 PDT
Comment on attachment 227499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227499&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38 > +#if defined(__has_include) && __has_include(<xpc/private.h>) no need for the defined() check > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:41 > +extern "C" void xpc_connection_get_audit_token(xpc_connection_t, audit_token_t*); I think we should be doing this *outside* of the #if, not in an #else, so we get errors if the signature changes. > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:32 > +#include "WebProcess.h" > #include "WebPage.h" this looks sorted wrong
Sam Weinig
Comment 8 2014-03-21 15:43:48 PDT
Committed r166103: <http://trac.webkit.org/changeset/166103>
Note You need to log in before you can comment on or make changes to this bug.