| Summary: | [WebKit2] Implement NetworkingContext::sourceApplicationAuditData() for WebKit2 | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Sam Weinig <sam> | ||||||||
| Component: | New Bugs | Assignee: | Sam Weinig <sam> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | commit-queue | ||||||||
| Priority: | P2 | ||||||||||
| Version: | 528+ (Nightly build) | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Bug Depends on: | 130551 | ||||||||||
| Bug Blocks: | |||||||||||
| Attachments: |
|
||||||||||
|
Description
Sam Weinig
2014-03-20 12:28:28 PDT
Created attachment 227318 [details]
Patch
Comment on attachment 227318 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227318&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38 > +#if defined(__has_include) && __has_include(<xpc/private.h>) No need for #if defined(__has_include). Committed r165985: <http://trac.webkit.org/changeset/165985> Re-opened since this is blocked by bug 130551 Created attachment 227487 [details]
Patch
Created attachment 227499 [details]
Patch
Comment on attachment 227499 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=227499&action=review > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:38 > +#if defined(__has_include) && __has_include(<xpc/private.h>) no need for the defined() check > Source/WebKit2/Platform/IPC/mac/ConnectionMac.cpp:41 > +extern "C" void xpc_connection_get_audit_token(xpc_connection_t, audit_token_t*); I think we should be doing this *outside* of the #if, not in an #else, so we get errors if the signature changes. > Source/WebKit2/WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:32 > +#include "WebProcess.h" > #include "WebPage.h" this looks sorted wrong Committed r166103: <http://trac.webkit.org/changeset/166103> |