Bug 130526 – ASSERTION FAILED: event == [NSApp currentEvent] hitting Command-+

• Component: WebKit2
• Status: RESOLVED FIXED

[Alexey Proskuryakov]

<rdar://problem/16371612>

[Alexey Proskuryakov]

Before r165356, it worked in a different way: this check wasn't an assertion, but a runtime one:

    if (!eventWasSentToWebCore && event == [NSApp currentEvent] && self == [[self window] firstResponder]) {
        _data->_page->handleKeyboardEvent(NativeWebKeyboardEvent(event, self));

The old approach was fragile, it relied on the fact that AppKit sends the synthesized event without updating [NSApp currentEvent], which is a very questionable behavior.

[Alexey Proskuryakov]

Created attachment 227316 [details]
proposed fix

[WebKit Commit Bot]

Comment on attachment 227316 [details]
proposed fix

Rejecting attachment 227316 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
 build commands failed:
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/TestController.o TestController.cpp normal x86_64 c++ com.apple.compilers.llvm.clang.1_0.compiler
	CompileC /Volumes/Data/EWS/WebKit/WebKitBuild/WebKitTestRunner.build/Release/WebKitTestRunner.build/Objects-normal/x86_64/PlatformWebViewMac.o mac/PlatformWebViewMac.mm normal x86_64 objective-c++ com.apple.compilers.llvm.clang.1_0.compiler
(2 failures)

Full output: http://webkit-queues.appspot.com/results/5080808234680320

[WebKit Commit Bot]

Comment on attachment 227316 [details]
proposed fix

Clearing flags on attachment: 227316

Committed r166000: <http://trac.webkit.org/changeset/166000>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.