Bug 130518

Summary: Remove remaining GTK+ unused parameter warnings from WebKit2
Product: WebKit Reporter: Martin Robinson <mrobinson>
Component: WebKit2Assignee: Martin Robinson <mrobinson>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cgarcia, commit-queue, gustavo
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Martin Robinson
Reported 2014-03-20 10:01:03 PDT
These warnings can hide potential problems and we didn't have them turned on before using CMake. Fixing them all at once makes sense.
Attachments
Patch (14.64 KB, patch)
2014-03-20 10:03 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 2014-03-20 10:03:41 PDT
Created attachment 227299 [details] Patch
WebKit Commit Bot
Comment 2 2014-03-20 10:06:07 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Sergio Villar Senin
Comment 3 2014-03-20 10:10:05 PDT
Comment on attachment 227299 [details] Patch Awesome cleanup
Martin Robinson
Comment 4 2014-03-20 10:21:24 PDT
Comment on attachment 227299 [details] Patch Clearing flags on attachment: 227299 Committed r165968: <http://trac.webkit.org/changeset/165968>
Martin Robinson
Comment 5 2014-03-20 10:21:28 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.