Bug 130493

Summary:

[PATCH] Improve CMake usage

Product:

WebKit

Reporter:

Ben Boeckel <mathstuf>

Component:

Tools / Tests

Assignee:

Nobody <webkit-unassigned>

Status:

NEW

Severity:

Normal

Priority:

Version:

528+ (Nightly build)

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Fixes warnings when using 3.0 (currently in the rc stage)	none
Removes a performance-costly string(REGEX REPLACE) with string(REPLACE)	none
Other, less critical string(REGEX REPLACE) removals	none
Replacement of string(REGEX REPLACE) with file(RELATIVE_PATH)	none
Avoid usage of deprecated LOCATION property	none

Ben Boeckel

Reported 2014-03-19 19:38:54 PDT

Here is a set of patches for improving CMake usage. They're currently split out since some might not be wanted (one bumps the minimum version to 2.8.7, some cosmetic things, and another for warning-less 2.8.12+ support). Once the patches are accepted, I'll make them into proper patch submissions (optionally squashed).

Attachments
Fixes warnings when using 3.0 (currently in the rc stage) (3.74 KB, patch) 2014-03-19 19:39 PDT, Ben Boeckel	no flags	Details Formatted Diff Diff
Removes a performance-costly string(REGEX REPLACE) with string(REPLACE) (1.15 KB, patch) 2014-03-19 19:40 PDT, Ben Boeckel	no flags	Details Formatted Diff Diff
Other, less critical string(REGEX REPLACE) removals (1.89 KB, patch) 2014-03-19 19:41 PDT, Ben Boeckel	no flags	Details Formatted Diff Diff
Replacement of string(REGEX REPLACE) with file(RELATIVE_PATH) (1.12 KB, patch) 2014-03-19 19:41 PDT, Ben Boeckel	no flags	Details Formatted Diff Diff
Avoid usage of deprecated LOCATION property (1.82 KB, patch) 2014-03-19 19:42 PDT, Ben Boeckel	no flags	Details Formatted Diff Diff
View All Add attachment proposed patch, testcase, etc.

Ben Boeckel

Comment 1 2014-03-19 19:39:35 PDT

Created attachment 227243 [details] Fixes warnings when using 3.0 (currently in the rc stage)

Ben Boeckel

Comment 2 2014-03-19 19:40:16 PDT

Created attachment 227244 [details] Removes a performance-costly string(REGEX REPLACE) with string(REPLACE)

Ben Boeckel

Comment 3 2014-03-19 19:41:03 PDT

Created attachment 227245 [details] Other, less critical string(REGEX REPLACE) removals

Ben Boeckel

Comment 4 2014-03-19 19:41:38 PDT

Created attachment 227246 [details] Replacement of string(REGEX REPLACE) with file(RELATIVE_PATH)

Ben Boeckel

Comment 5 2014-03-19 19:42:07 PDT

Created attachment 227247 [details] Avoid usage of deprecated LOCATION property

Ben Boeckel

Comment 6 2014-03-19 20:50:52 PDT

Comment on attachment 227244 [details] Removes a performance-costly string(REGEX REPLACE) with string(REPLACE) View in context: https://bugs.webkit.org/attachment.cgi?id=227244&action=review > Source/cmake/WebKitMacros.cmake:196 > + string(REPLACE "/" "\\\\\\\\" _sourcegroup "${_path}") The backslashes may need to be halved since they're not going through a regex anymore. I don't have a setup which uses source_group at all, so this needs testing from someone with XCode or VS.

Note You need to log in before you can comment on or make changes to this bug.