Bug 130490

Summary: media/video-remote-control-playpause.html frequently fails on the bots
Product: WebKit Reporter: Eric Carlson <eric.carlson>
Component: MediaAssignee: Andy Estes <aestes>
Status: REOPENED ---    
Severity: Normal CC: aestes, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: 528+ (Nightly build)   
Hardware: Unspecified   
OS: Unspecified   

Description Eric Carlson 2014-03-19 17:59:52 PDT
This test passes on my machines with --iterations=10000 but frequently fails on the bots.
Comment 1 Eric Carlson 2014-03-19 18:06:47 PDT
Marked as flakey in https://trac.webkit.org/r165937 while I try to reproduce it.
Comment 2 Andy Estes 2023-08-18 10:50:16 PDT
Looks like this test is no longer marked flaky in TestExpectations, but the test still flakily crashes and times out according to https://results.webkit.org/?suite=layout-tests&test=media%2Fvideo-remote-control-playpause.html
Comment 3 Radar WebKit Bug Importer 2023-08-18 10:52:56 PDT
<rdar://problem/114097537>
Comment 4 Andy Estes 2023-08-18 10:53:54 PDT
Pull request: https://github.com/WebKit/WebKit/pull/16840
Comment 5 EWS 2023-08-18 11:03:41 PDT
Committed 267046@main (662d6eb482e6): <https://commits.webkit.org/267046@main>

Reviewed commits have been landed. Closing PR #16840 and removing active labels.
Comment 6 Andy Estes 2023-08-18 11:04:36 PDT
I don't know what causes the test to time out, but I think I understand why it crashes sometimes. In VideoFullscreenManager::removeContext, videoElement can be null here:
```
    RefPtr<HTMLVideoElement> videoElement = model->videoElement();
    ...
    m_videoElements.remove(*videoElement);
```
Comment 7 Andy Estes 2023-08-18 11:04:51 PDT
Reopening